Add create_service to AsyncClient #1202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxop
reviewed
May 21, 2021
There was a problem hiding this comment.
A more elegant solution might be to add a class variable ServiceProxyClass, which on the Client class is set to ServiceProxy and on the AsyncClient class is set to AsyncServiceProxy. Then both of these methods (bind and create_service) can be updated to have return self.ServiceProxyClass(...) and the AsyncClient class can be reduced to simply
class AsyncClient(Client):
ServiceProxyClass = AsyncServiceProxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1168
create_service needs to be overridden to be supported for the AsyncClient.