Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing service creation for AsyncClient in the elegant way #1389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/zeep/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ class Client:

"""

ServiceProxyClass = ServiceProxy

_default_transport: typing.Union[Transport, AsyncTransport] = Transport

def __init__(
Expand Down Expand Up @@ -139,7 +141,7 @@ def create_service(self, binding_name, address):
"No binding found with the given QName. Available bindings "
"are: %s" % (", ".join(self.wsdl.bindings.keys()))
)
return ServiceProxy(self, binding, address=address)
return self.ServiceProxyClass(self, binding, address=address)

def create_message(self, service, operation_name, *args, **kwargs):
"""Create the payload for the given operation.
Expand Down Expand Up @@ -225,6 +227,8 @@ def __exit__(self, exc_type=None, exc_value=None, traceback=None):
class AsyncClient(Client):
_default_transport = AsyncTransport

ServiceProxyClass = AsyncServiceProxy

def bind(
self,
service_name: typing.Optional[str] = None,
Expand Down