Properly close 'file://' resources #1393
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I bumped into this when opening several wsdl which in turn opened lots
of xsd, with 'file://' scheme.
The issue was that the
resp.raw.close
norresp.raw.release_conn
setin the
FileAdapter
were ever called.It's unclear to me whether this should be fixed in requests. It doesn't
do that great a job at resource management for the naive user aka
Human™. It makes sense to me that exhaustively reading
Response.raw
should close it unless the caller explicitly set
stream
on therequest. Probably by using this
closing
pattern in the generator inResponse.iter_content
.Workarounds without this fix:
open the file as a context manager.
zeep.cache
to hide duplicate open resources.