Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pieces to parcel #10

Merged
merged 21 commits into from
Nov 11, 2019
Merged

Add pieces to parcel #10

merged 21 commits into from
Nov 11, 2019

Conversation

jacobdekeizer
Copy link
Contributor

@jacobdekeizer jacobdekeizer commented Nov 10, 2019

Description

Add pieces resource to configure the pieces that are going te be shipped.
I also fixed some errors in the readme file, like company_name has to be company, otherwise you get a 400 bad request.

Motivation and context

This change allows a developer to configure the pieces for a parcel shipment.
The package in its current state has a harcoded shipment piece.

How has this been tested?

I created shipments with the new pieces functionality.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change requires a change to the documentation, I have updated it accordingly.
  • My code follows the code style of this project.

@jacobdekeizer
Copy link
Contributor Author

jacobdekeizer commented Nov 10, 2019

@mvdnbrk If you create multiple pieces, only 1 trackerCode and labelId is returned from the Shipments class.
How would you like me to solve that to preserve backwards compatibility or can I make a breaking change to return an array of labels.

@mvdnbrk mvdnbrk self-assigned this Nov 10, 2019
@mvdnbrk
Copy link
Owner

mvdnbrk commented Nov 10, 2019

Thanks! Could you add tests for this?

@jacobdekeizer
Copy link
Contributor Author

@mvdnbrk I added the tests.

@mvdnbrk mvdnbrk merged commit 9374cb7 into mvdnbrk:master Nov 11, 2019
@mvdnbrk mvdnbrk added this to the v0.5.0 milestone Nov 11, 2019
@mvdnbrk
Copy link
Owner

mvdnbrk commented Nov 11, 2019

Released in v0.5.0.

@mvdnbrk mvdnbrk mentioned this pull request Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants