Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for an additional address line #49

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Add support for an additional address line #49

merged 1 commit into from
Aug 7, 2020

Conversation

Thorry84
Copy link
Contributor

@Thorry84 Thorry84 commented Aug 5, 2020

Added support for an additional address line in addresses, this is often required for international shipments and can be useful for NL shipments.

Description

Added a new property to address, in line with DHL naming and existing code.

Motivation and context

This code adds a missing feature to the API which DHL provides.

How has this been tested?

Created a label with an extra line, checked to new line was submitted to DHL.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change requires a change to the documentation, I have updated it accordingly.
  • My code follows the code style of this project.

@mvdnbrk mvdnbrk merged commit 71e4208 into mvdnbrk:master Aug 7, 2020
@mvdnbrk
Copy link
Owner

mvdnbrk commented Aug 7, 2020

Thanks!

@Thorry84
Copy link
Contributor Author

Thorry84 commented Aug 7, 2020

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants