Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11, drop below 3.8, update deps #159

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Jun 25, 2023

Add Python 3.11 and 3.10, drop 3.7. Also update dependencies to the latest versions.

@metazool
Copy link

Hi @eumiro - I'm looking through the outstanding PRs with an eye to helping with project maintenance.

Is it just the walrus operator in https://github.com/mvexel/overpass-api-python-wrapper/pull/160/files that's back-incompatible? The rest looks good, it's a small syntax advantage that might make the library less widely usable

@mvexel mvexel mentioned this pull request Feb 7, 2024
@mvexel
Copy link
Owner

mvexel commented Feb 7, 2024

Python 3.7 is EOL so I think it's prudent to drop support, what do you think @metazool @eumiro ?

@@ -8,7 +8,7 @@ jobs:
strategy:
max-parallel: 5
matrix:
python-version: [3.7, 3.8, 3.9]
python-version: ["3.8", "3.9", "3.10", "3.11"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include 3.12?

geojson = ">=3.0.1"
pytest = "7.4.0"
requests = ">=2.31.0"
shapely = ">=2.0.1"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New major version of shapely, are we confident we won't break things on our end?

@mvexel mvexel merged commit ec583e6 into mvexel:main Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants