Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable csv response format #60

Merged
merged 1 commit into from
Aug 21, 2016
Merged

enable csv response format #60

merged 1 commit into from
Aug 21, 2016

Conversation

nebulon42
Copy link
Contributor

@nebulon42 nebulon42 commented Jul 7, 2016

Implicitly the CSV response format would already work by specifying e.g. responseformat='csv("addr:street", "addr:place", "addr:housenumber";true;";")'. But instead of trying to parse JSON the raw response should be returned.

Failed checks are timeout errors.

@nebulon42
Copy link
Contributor Author

@mvexel Would you have time for a review? I have two smaller projects in the pipeline I can't reasonably open source without this change being merged and released. Thanks a lot!

@nebulon42
Copy link
Contributor Author

I'm no longer sure why I need the CSV output anyway. It would be possible to parse the JSON and transform to CSV in the code.

@mvexel mvexel merged commit 68f6dfe into mvexel:master Aug 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants