Skip to content

Commit

Permalink
Fix redraws (#293)
Browse files Browse the repository at this point in the history
* Attempt to reproduce #292

* Fix repaint corner cases
  • Loading branch information
mvlabat authored Jul 30, 2024
1 parent 91c6b64 commit 9b9894d
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 3 deletions.
16 changes: 15 additions & 1 deletion examples/side_panel.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use bevy::{prelude::*, window::PrimaryWindow};
use bevy::{prelude::*, window::PrimaryWindow, winit::WinitSettings};
use bevy_egui::{EguiContexts, EguiPlugin};

#[derive(Default, Resource)]
Expand All @@ -16,6 +16,7 @@ struct OriginalCameraTransform(Transform);

fn main() {
App::new()
.insert_resource(WinitSettings::desktop_app())
.add_plugins(DefaultPlugins)
.add_plugins(EguiPlugin)
.init_resource::<OccupiedScreenSpace>()
Expand All @@ -26,6 +27,7 @@ fn main() {
}

fn ui_example_system(
mut is_last_selected: Local<bool>,
mut contexts: EguiContexts,
mut occupied_screen_space: ResMut<OccupiedScreenSpace>,
) {
Expand All @@ -35,6 +37,18 @@ fn ui_example_system(
.resizable(true)
.show(ctx, |ui| {
ui.label("Left resizeable panel");
if ui
.add(egui::widgets::Button::new("A button").selected(!*is_last_selected))
.clicked()
{
*is_last_selected = false;
}
if ui
.add(egui::widgets::Button::new("Another button").selected(*is_last_selected))
.clicked()
{
*is_last_selected = true;
}
ui.allocate_rect(ui.available_rect_before_wrap(), egui::Sense::hover());
})
.response
Expand Down
21 changes: 19 additions & 2 deletions src/systems.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@ use bevy::{
ButtonState,
},
log,
prelude::{Entity, EventReader, Query, Resource, Time},
prelude::{Entity, EventReader, NonSend, Query, Resource, Time},
time::Real,
window::{CursorMoved, RequestRedraw},
winit::{EventLoopProxy, WakeUp},
};
use std::marker::PhantomData;
use std::{marker::PhantomData, time::Duration};

#[allow(missing_docs)]
#[derive(SystemParam)]
Expand Down Expand Up @@ -482,6 +483,7 @@ pub fn process_output_system(
mut egui_clipboard: bevy::ecs::system::ResMut<crate::EguiClipboard>,
mut event: EventWriter<RequestRedraw>,
#[cfg(windows)] mut last_cursor_icon: Local<bevy::utils::HashMap<Entity, egui::CursorIcon>>,
event_loop_proxy: Option<NonSend<EventLoopProxy<WakeUp>>>,
) {
let mut should_request_redraw = false;

Expand Down Expand Up @@ -530,6 +532,21 @@ pub fn process_output_system(
let needs_repaint = !context.render_output.is_empty();
should_request_redraw |= ctx.has_requested_repaint() && needs_repaint;

// The resource doesn't exist in the headless mode.
if let Some(event_loop_proxy) = &event_loop_proxy {
// A zero duration indicates that it's an outstanding redraw request, which gives Egui an
// opportunity to settle the effects of interactions with widgets. Such repaint requests
// are processed not immediately but on a next frame. In this case, we need to indicate to
// winit, that it needs to wake up next frame as well even if there are no inputs.
//
// TLDR: this solves repaint corner cases of `WinitSettings::desktop_app()`.
if let Some(Duration::ZERO) =
ctx.viewport(|viewport| viewport.input.wants_repaint_after())
{
let _ = event_loop_proxy.send_event(WakeUp);
}
}

#[cfg(feature = "open_url")]
if let Some(egui::output::OpenUrl { url, new_tab }) = platform_output.open_url {
let target = if new_tab {
Expand Down

0 comments on commit 9b9894d

Please sign in to comment.