Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename googletest and yaml-cpp to align with bzlmod versions #255

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

lalten
Copy link
Contributor

@lalten lalten commented Jan 28, 2024

Extracted from / in preparation for #238

No functional or version changes in this one.

If downstream consumers of rules_ros2 depend on com_google_googletest or yaml_cpp they need to either rename their deps or properly declare their dependencies instead of relying on rules_ros2's transitive deps.

@mvukov mvukov enabled auto-merge (squash) January 29, 2024 20:26
@mvukov mvukov merged commit 58b56ea into mvukov:main Jan 29, 2024
6 checks passed
@lalten lalten deleted the rename-googletest-and-yaml-cpp branch January 29, 2024 20:41
@lalten lalten mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants