Fix edgecolor in catplot with kind='bar'

Fixes #3542
mwaskom · Nov 4, 2023 · 4b7f341 · 4b7f341
1 parent 3351a17
commit 4b7f341
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/seaborn/categorical.py b/seaborn/categorical.py
@@ -2830,7 +2830,10 @@ def catplot(
         if saturation < 1:
             color = desaturate(color, saturation)
 
-    edgecolor = p._complement_color(kwargs.pop("edgecolor", default), color, p._hue_map)
+    if kind in ["strip", "swarm"]:
+        edgecolor = p._complement_color(
+            kwargs.pop("edgecolor", default), color, p._hue_map
+        )
 
     width = kwargs.pop("width", 0.8)
     dodge = kwargs.pop("dodge", False if kind in undodged_kinds else "auto")

diff --git a/tests/test_categorical.py b/tests/test_categorical.py
@@ -2307,7 +2307,7 @@ def test_err_kws(self, fill):
             dict(data="long", x="a", y="y", errorbar=("pi", 50)),
             dict(data="long", x="a", y="y", errorbar=None),
             dict(data="long", x="a", y="y", capsize=.3, err_kws=dict(c="k")),
-            dict(data="long", x="a", y="y", color="blue", ec="green", alpha=.5),
+            dict(data="long", x="a", y="y", color="blue", edgecolor="green", alpha=.5),
         ]
     )
     def test_vs_catplot(self, long_df, wide_df, null_df, flat_series, kwargs):