Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming: Ribbon -> Band, Interval -> Range #2945

Merged
merged 2 commits into from
Aug 13, 2022
Merged

Renaming: Ribbon -> Band, Interval -> Range #2945

merged 2 commits into from
Aug 13, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Aug 8, 2022

  • Band is more consistent with err_style="band" in the existing lineplot and is shorter
  • Range is more about brevity than consistency, but Interval could be useful as a stat in the future. I went back and forth on this one a lot, Span could also work but I think that will be held in reserve for a bar-type interval mark. FWIW Range is consistent with geom_pointrange/geom_linerange.

@mwaskom mwaskom added this to the v0.12.0 milestone Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #2945 (4438bb4) into master (a1ede5e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2945   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines       22996    22996           
=======================================
  Hits        22607    22607           
  Misses        389      389           
Impacted Files Coverage Δ
seaborn/_marks/area.py 96.25% <100.00%> (ø)
seaborn/_marks/line.py 100.00% <100.00%> (ø)
seaborn/objects.py 100.00% <100.00%> (ø)
tests/_marks/test_area.py 100.00% <100.00%> (ø)
tests/_marks/test_line.py 100.00% <100.00%> (ø)

@mwaskom mwaskom merged commit 04969a3 into master Aug 13, 2022
@mwaskom mwaskom deleted the rename/spans branch August 13, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant