Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Pairwise dropna in PairGrid. Closes #407. #409

Closed
wants to merge 8 commits into from
Closed

ENH: Pairwise dropna in PairGrid. Closes #407. #409

wants to merge 8 commits into from

Conversation

jseabold
Copy link
Contributor

PR for #407.

@mwaskom
Copy link
Owner

mwaskom commented Dec 24, 2014

It would be ideal to wrap up any of these changes with those discussed in #361.

@jseabold
Copy link
Contributor Author

Bump minimum pandas version on travis or fix to support 0.12.0 (released 7/13)?

@jseabold
Copy link
Contributor Author

#361 is a bit of an orthogonal issue AFAICT, but I can take a look at that too. This preserves the current behavior, but now handles NA (to the extent the test suite covers the existing sorts in axisgrid.py).

@mwaskom
Copy link
Owner

mwaskom commented Dec 24, 2014

Bump minimum pandas version on travis or fix to support 0.12.0 (released 7/13)?

The aim is to support Debian stable, though I always have a hard time figuring out what that is and usually wait for @yarikoptic to yell at me :)

@jseabold
Copy link
Contributor Author

Fair enough, I'll fix it up.

@mwaskom
Copy link
Owner

mwaskom commented Dec 24, 2014

Well based on this I think "debian stable backports" is running 0.13 (now?). Would inplace=False work there?

@jseabold
Copy link
Contributor Author

No, I don't think this was settled by the 0.13.x series either. I've worked around this before IIRC. Will fix up later (got to run now).

@mwaskom
Copy link
Owner

mwaskom commented Dec 26, 2014

So from what I can tell for the narrow version of this PR that preserves current behavior, wouldn't something like

hue_names = np.sort(data[hue].dropna().unique())

work?

@jseabold
Copy link
Contributor Author

I think so, yeah. The only benefit of this version is that it also supports the new categorical dtype in an expected way, if a desired change. The only break would be if I changed np.unique to pd.unique or vice versa without a sort, which I don't think I did.

@mwaskom
Copy link
Owner

mwaskom commented Dec 27, 2014

I'd say just do the simpler thing for now and not worry about categoricals, which I'll handle with a broader change to how factor orders are determined before 0.6 goes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants