-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Pairwise dropna in PairGrid. Closes #407. #409
Conversation
It would be ideal to wrap up any of these changes with those discussed in #361. |
Bump minimum pandas version on travis or fix to support 0.12.0 (released 7/13)? |
#361 is a bit of an orthogonal issue AFAICT, but I can take a look at that too. This preserves the current behavior, but now handles NA (to the extent the test suite covers the existing sorts in |
The aim is to support Debian stable, though I always have a hard time figuring out what that is and usually wait for @yarikoptic to yell at me :) |
Fair enough, I'll fix it up. |
Well based on this I think "debian stable backports" is running 0.13 (now?). Would |
No, I don't think this was settled by the 0.13.x series either. I've worked around this before IIRC. Will fix up later (got to run now). |
So from what I can tell for the narrow version of this PR that preserves current behavior, wouldn't something like hue_names = np.sort(data[hue].dropna().unique()) work? |
I think so, yeah. The only benefit of this version is that it also supports the new |
I'd say just do the simpler thing for now and not worry about categoricals, which I'll handle with a broader change to how factor orders are determined before 0.6 goes out. |
PR for #407.