Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistent plurals ('sticks'->'stick'). #434

Merged
merged 1 commit into from
Jan 28, 2015

Conversation

ahjulstad
Copy link

Also added documention default setting ('box')

@mwaskom
Copy link
Owner

mwaskom commented Jan 28, 2015

Thanks, as you'll note in the code, passing either will work because it just checks what the string starts with. But good to be consistent, nice catch! Generally the numpy docstring rules are not to state default values in the Parameters section because they're redundant with the function signature, and provide an opportunity for the docs to get out of sync if that changes. Also the addition of that clause is causing the linting tests to fail as the line is too long.

@ahjulstad
Copy link
Author

OK. Removed the default statement and rebased.

(Really small change, but I like practicing my git skills on simple stuff first...)

@mwaskom
Copy link
Owner

mwaskom commented Jan 28, 2015

Looks great, Thanks!

mwaskom added a commit that referenced this pull request Jan 28, 2015
Fixed inconsistent plurals ('sticks'->'stick').
@mwaskom mwaskom merged commit 6c366a9 into mwaskom:master Jan 28, 2015
mwaskom added a commit that referenced this pull request Mar 13, 2015
mwaskom added a commit that referenced this pull request Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants