fixed typos in readme #16
Conversation
immer.js
Outdated
|
|
||
| //values either than undefined will trigger warning; | ||
| !Object.is(maybeVoidReturn, undefined) && | ||
| console.warn(`Immer callback expects no return value. However %s was returned`, prettify(maybeVoidReturn)) |
There was a problem hiding this comment.
Since this is a pretty clear warning, I would keep it simple and just use typeof maybeVoidReturn without prettiefying.
There was a problem hiding this comment.
I did that initially . But null ,objects , arrays all printed object . I was thinking I could be more specific. I would use type of instead then
| @@ -32,18 +32,32 @@ acorn-globals@^4.0.0: | |||
| dependencies: | |||
| acorn "^5.0.0" | |||
|
|
|||
| acorn@^5.0.0, acorn@^5.1.2: | |||
There was a problem hiding this comment.
any idea where these yarn.lock changes are coming from? Maybe a different yarn version (I am on 1.3.2). Since there are no changes in package json, I would expect none here. You can fix it by usinggit checkout master yarn.lock.
There was a problem hiding this comment.
Hmm master yarn was not up to date either, just pushed.
There was a problem hiding this comment.
Silly me. I add eslint and prettier to almost every project. I removed it after. That should explain that I will fix it
|
Feel free to leave / add prettier setup😊. I have it set up through my ide
atm. I think code is currently formatted with 4 spaces, no semi, double
quote.
…On ma 1 jan. 2018 14:09 Gregory Assasie ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In yarn.lock
<#16 (comment)>:
> @@ -32,18 +32,32 @@ acorn-globals@^4.0.0:
dependencies:
acorn "^5.0.0"
-acorn@^5.0.0, acorn@^5.1.2:
Silly me. I add eslint and prettier to almost every project. I removed it
after. That should explain that I will fix it
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#16 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhC9L0ONNEoy85gv_10vwrPykhl5Gks5tGNj6gaJpZM4RP-LB>
.
|
|
Sure. I will do that ;) |
|
Merged, thanks a lot! |
No description provided.