-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry flaky UI tests in CI #1262
Conversation
Thank you for making this pull request. Did you know? You can try it on Binder: or . Also, the version of Jupytext developed in this PR can be installed with
(this requires |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
==========================================
- Coverage 95.93% 95.91% -0.03%
==========================================
Files 29 29
Lines 4476 4476
==========================================
- Hits 4294 4293 -1
- Misses 182 183 +1 ☔ View full report in Codecov by Sentry. |
Hi @mahendrapaipuri , I am not sure this test is "flaky" - I had relaunched the publish CI multiple times and it failed on each attempt (https://github.com/mwouts/jupytext/actions/runs/9958694800/job/28138283717) - curious to learn what makes you think that retry would improve this? |
Well, if you look into the CI runs of this PR, playwright actually marked that test as flaky. I guess the first run of that test is always a failure and it passes in the subsequent retries. Anyways, that test does not add any value and hence, I removed it. I added a workflow to update snapshots directly from a PR by commenting "update snapshots". Let me know what you think! |
abd3cc8
to
a34d772
Compare
Thank you @mahendrapaipuri , this looks great! I will have to fix #1266 first but I am looking forward to taking your PR! Thanks |
Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
* Bump actions versions Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
See comment
Closes #1230