Add the Quarto format (.qmd files) to Jupytext #846
Conversation
| def quarto_version(): | ||
| """Quarto's version number""" | ||
| try: | ||
| return quarto("--version").strip() |
There was a problem hiding this comment.
As long as there is negligible overhead for quarto invocations I don't think that this check is worth the execution time. Quarto is early enough in its dev cycle that we can reasonably expect that nearly all users will have a recent version (and we can reference the minimum required version in the jupytext docs).
If this isn't persuasive to you then I'd suggest two other approaches to avoid the overhead:
- Only detect the
quarto_versionafter an error has occurred (and in that case print the informative message that they need a newer version; or - Detect the quarto version from the filesystem. Once you know the directory containing
quartoyou can find the version file at../share/version(if there is no version file then it's the development version which you can assume meets the minimum criteria).
There was a problem hiding this comment.
I have one idea about how to make quarto --version faster so that no filesystem check is required --- will report back on whether this worked out soon.
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
==========================================
- Coverage 99.11% 97.67% -1.44%
==========================================
Files 106 108 +2
Lines 10345 10437 +92
==========================================
- Hits 10253 10194 -59
- Misses 92 243 +151
Continue to review full report at Codecov.
|
* suggestions for quarto docs * Update formats.md
Closes #837