Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More map by keyPath #1121

Merged
merged 10 commits into from
Jan 15, 2020
Merged

More map by keyPath #1121

merged 10 commits into from
Jan 15, 2020

Conversation

RomanPodymov
Copy link
Collaborator

Hello.
Thank you for PromiseKit.
In this pull request I added more mapping functions that accepts KeyPath instead of a closure (started in #1118).

@mxcl
Copy link
Owner

mxcl commented Jan 14, 2020

I have confirmed that Swift 5.2 adds the SE proposal that KeyPaths are compiler converted to functions with literal syntax, thus this addition is welcome, but should be guarded with #if swift(<5.2) to prevent collision.

@RomanPodymov
Copy link
Collaborator Author

Hello @mxcl
I see that the Travis CI build could not complete due to an error. How can I restart it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants