Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is sloooow #1424

Closed
axelboc opened this issue Sep 27, 2024 · 8 comments · Fixed by #1425
Closed

CI is sloooow #1424

axelboc opened this issue Sep 27, 2024 · 8 comments · Fixed by #1425

Comments

@axelboc
Copy link
Collaborator

axelboc commented Sep 27, 2024

You've probably noticed it. Not sure if it's a temporary slow down or if it's something to do with the recent change to test all supported Python versions. https://github.com/mxcube/mxcubeweb/actions/runs/11069955541

image

@marcus-oscarsson
Copy link
Member

I think its temporary, it was quite quick earlier today. The pages build took forever though.

@fabcor-maxiv
Copy link
Contributor

Nothing obvious on https://www.githubstatus.com/

@marcus-oscarsson
Copy link
Member

marcus-oscarsson commented Sep 27, 2024

Looks like the actions are stuck on

micromamba list
  /home/runner/micromamba-bin/micromamba list -r /home/runner/micromamba -n mxcubeweb

A bit strange, considering that is just listing the installed packages. It does not seem to matter if we are only running one python version or several simultaneously

@fabcor-maxiv
Copy link
Contributor

There was a new major release of mamba and micromamba. Versions 2.0.0 for both. Maybe something broke.

We can try:

- uses: mamba-org/setup-micromamba@v1
  with:
    micromamba-version: '1.5.10-0' # any version from https://github.com/mamba-org/micromamba-releases

@fabcor-maxiv
Copy link
Contributor

mamba-org/setup-micromamba#225

@marcus-oscarsson
Copy link
Member

I think thats it !

@fabcor-maxiv
Copy link
Contributor

fabcor-maxiv commented Sep 27, 2024

I am a bit reluctant to make a fix for it that would involve pinning the version of micromamba...

  • If we are lucky, there will be a fix in micromamba (or the setup-micromamba action) soon enough.
  • Do we really want to pin the version of micromamba? Would dependabot help us keep the pinned version up to date?

fabcor-maxiv added a commit to fabcor-maxiv/mxcubeweb that referenced this issue Sep 27, 2024
Pin version of micromamba to `1.5.10-0` in GitHub Actions workflows
because of following issue:
mamba-org/setup-micromamba#225

GitHub: fix mxcube#1424
fabcor-maxiv added a commit to fabcor-maxiv/mxcubeweb that referenced this issue Sep 27, 2024
Pin version of micromamba to `1.5.10-0` in GitHub Actions workflows
because of following issue:
mamba-org/setup-micromamba#225

GitHub: fix mxcube#1424
marcus-oscarsson pushed a commit that referenced this issue Sep 27, 2024
Pin version of micromamba to `1.5.10-0` in GitHub Actions workflows
because of following issue:
mamba-org/setup-micromamba#225

GitHub: fix #1424
@fabcor-maxiv
Copy link
Contributor

For info:

Looks like in principle the root issue has been fixed and the fixed version has been released (in version 2.0.1):

So I assume that in principle we could remove the pin (I have not tried it). On the other hand, maybe it is not a bad idea to wait a bit longer until micromamba v2 is more stable in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants