Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout argument for async #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dat-boris
Copy link

A simple change to allow timeout parameter to be passed to feature implemented in:

mhevery/jasmine-node#142

Please do let me know if there's any feedback.

Thanks for this great snippet that make life easier for async test.

@johntimothybailey
Copy link

This actually resolves an issue we discussed today where we needed a test to wait longer (due to various conditions). Granted, having to design for this reveals a larger flaw, but when pinned and need a solution ... well it's convention with configuration like this request that helps

@ChristophGr
Copy link

Just applied it to our test-suite. We have tests that take up to 10 seconds in older firefox-versions (we have to support). This made our tests work again on the build-server.

@traviswimer
Copy link

Seriously, this pull request deserves some attention. Would make some awesome code even awesomer.

@theladyjaye
Copy link

+1

@antialias
Copy link

bump

@mxriverlynn
Copy link
Owner

at this point, i don't plan to maintain this code repo. jasmine v2.x has this feature built in without needing an additional library. if someone is still working with jasmine v1.0 and wants to maintain this library, let me know and i'll transfer ownership of this library to you

@antialias
Copy link

@derickbailey understood, but if it's any motivation to you to continue work on this feature, it doesn't look like it exists in Jasmine 2 docs. If a timeout for a specific spec is desired, they recommend storing the old timeout value, setting it, then resetting it after the spec:

http://jasmine.github.io/2.0/introduction.html#section-44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants