Skip to content

Commit

Permalink
feat(webkit): roll to r2080 (microsoft#32721)
Browse files Browse the repository at this point in the history
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
  • Loading branch information
3 people committed Sep 20, 2024
1 parent cdcaa7f commit fccb8a1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion packages/playwright-core/browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
},
{
"name": "webkit",
"revision": "2079",
"revision": "2080",
"installByDefault": true,
"revisionOverrides": {
"mac10.14": "1446",
Expand Down
8 changes: 2 additions & 6 deletions tests/library/browsercontext-storage-state.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,7 @@ it('should work when service worker is intefering', async ({ page, context, serv
expect(storageState.origins[0].localStorage[0]).toEqual({ name: 'foo', value: 'bar' });
});

it('should set local storage in third-party context', async ({ contextFactory, server, browserName }) => {
it.fixme(browserName === 'webkit', 'look into setStorageBlockingPolicy');

it('should set local storage in third-party context', async ({ contextFactory, server }) => {
const context = await contextFactory({
storageState: {
cookies: [],
Expand All @@ -303,9 +301,7 @@ it('should set local storage in third-party context', async ({ contextFactory, s
await context.close();
});

it('should roundtrip local storage in third-party context', async ({ page, contextFactory, server, browserName }) => {
it.fixme(browserName === 'webkit', 'look into setStorageBlockingPolicy');

it('should roundtrip local storage in third-party context', async ({ page, contextFactory, server }) => {
await page.goto(server.EMPTY_PAGE);
const frame = await attachFrame(page, 'frame1', server.CROSS_PROCESS_PREFIX + '/empty.html');
await frame.evaluate(() => window.localStorage.setItem('name1', 'value1'));
Expand Down
4 changes: 3 additions & 1 deletion tests/library/trace-viewer.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ test('should complain about newer version of trace in old viewer', async ({ show
test('should properly synchronize local and remote time', async ({ showTraceViewer, asset }, testInfo) => {
const traceViewer = await showTraceViewer([asset('trace-remote-time-diff.zip')]);
// The total duration should be sub 10s, rather than 16h.
await expect(traceViewer.page.locator('.timeline-time').last()).toHaveText('8.5s');
await expect.poll(async () =>
parseInt(await traceViewer.page.locator('.timeline-time').last().innerText(), 10)
).toBeLessThan(10);
});

test('should contain action info', async ({ showTraceViewer }) => {
Expand Down

0 comments on commit fccb8a1

Please sign in to comment.