optmize code

mxsm · Jan 1, 2024 · 7b36433 · 7b36433
1 parent 95ac2e0
commit 7b36433
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/tcp/codec/Codec.java b/eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/tcp/codec/Codec.java
@@ -103,7 +103,8 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf in, List<Object> out) t
         if (in == null) {
             return;
         }
-        if (in.readableBytes() < CONSTANT_MAGIC_FLAG.length + VERSION.length + 4 + 4) {
+        final int prefixLength = CONSTANT_MAGIC_FLAG.length + VERSION.length;
+        if (in.readableBytes() < prefixLength + 4 + 4) {
             // Not enough data to read the package length and header length
             return;
         }
@@ -112,12 +113,12 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf in, List<Object> out) t
         validateFlagAndVersion(flagBytes, versionBytes, ctx);
         final int packageLength = in.readInt();
         final int headerLength = in.readInt();
-        if (in.readableBytes() < packageLength - 13) {
+        if (in.readableBytes() < packageLength - prefixLength) {
             // Not enough data yet, reset the reader index and wait for more data
             in.resetReaderIndex();
             return;
         }
-        final int bodyLength = packageLength - CONSTANT_MAGIC_FLAG.length - VERSION.length - headerLength;
+        final int bodyLength = packageLength - prefixLength - headerLength;
         Header header = parseHeader(in, headerLength);
         Object body = parseBody(in, header, bodyLength);