Add support for mounting and unmounting archives and repositories #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `mount` and `umount` commands and associated options. The implementation was very similar to how prune was implemented. I tested the changes by pointing borgtui to these changes: ``` $ cargo run -q -- -p real mount ssh://<my-repo>/./repo test-mount $ ls -l test-mount real-2023-04-23:16:25:20 real-2023-04-23:23:27:23 ... $ cargo run -q -- -p real umount test-mount $ ls -l test-mount $ ```
Unfortunately borg doesn't seem to handle umount errors gracefully nor provides message IDs for common mount failures (directory doesn't exist, etc)
myOmikron
requested changes
May 3, 2023
|
Do you plan on adding more methods? If so, I'd wait with a new release. Unfortunaly, I currently don't have the time, to implement more myself, but I'm happy to review PRs :) |
|
Thanks for your patience with this PR!
I plan on adding archive contents and borg support but that might be a few weeks away. Depending on what |
|
Okay, than I'll issue the release right now, and another for the other methods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
mountandumountcommands and associated options. The implementation was very similar to how prune was implemented. I tested the changes by pointing borgtui to these changes: