Merge pull request #324 from hazendaz/master

Use correct exception and add some comments
mybatis · Nov 11, 2023 · d38bc31 · d38bc31
2 parents ddffa8e + 68c5579
commit d38bc31
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/main/java/org/apache/ibatis/migration/CommandLine.java b/src/main/java/org/apache/ibatis/migration/CommandLine.java
@@ -30,6 +30,7 @@
 import org.apache.ibatis.migration.utils.Util;
 
 public class CommandLine {
+  // Leave this non static as it is messed with in this project tests
   private final PrintStream console = System.out;
   private final String[] args;
 

diff --git a/src/test/java/org/apache/ibatis/migration/MigratorTest.java b/src/test/java/org/apache/ibatis/migration/MigratorTest.java
@@ -24,6 +24,7 @@
 import com.github.stefanbirkner.systemlambda.SystemLambda;
 
 import java.io.File;
+import java.io.IOException;
 import java.io.PrintWriter;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -55,7 +56,7 @@ class MigratorTest {
   private static Properties env;
 
   @BeforeAll
-  static void setup() throws Exception {
+  static void setup() throws IOException {
     dir = Resources.getResourceAsFile("org/apache/ibatis/migration/example");
     env = Resources.getResourceAsProperties("org/apache/ibatis/migration/example/environments/development.properties");
   }
@@ -80,6 +81,7 @@ void testStatusContainsNoPendingEntriesUsingStatusShorthand() throws Exception {
     assertTrue(output.contains("...pending..."));
   }
 
+  // TODO This causes hsqldb 2.7.1 or 2.7.2 to blow up
   @Test
   @Order(3)
   void testUpCommandWithSpecifiedSteps() throws Exception {