Review Backend - Phop #1

ph0pz · 2023-04-28T08:04:04Z

Candidate Table with API and Authorization to manage Candidate

Candidate Table including attributes CandidateId , StatusId , Name , Email, Score, InterviewDate , PhoneNumber.

[POST] api/user/register : register a new user to manage candidate.
[POST] api/user/login : login with username and password that register to manage Candidate's API.

[GET] api/todo : get all candidate data in table.
[GET] api/todo/{CandidateId} get only candidate by the CandidateId.
[POST] api/todo : push the new candidate with information of the candidate to the table.
[PUT] api/todo/{CandidateId} : update the candidate information.
[DELETE] api/todo/{CandidateId} : delete the candidate by CandidateId.

6_Backend/ToDoAPI/ToDoAPI/Controllers/CandidateController.cs

6_Backend/ToDoAPI/ToDoAPI/Controllers/ScoreController.cs

KornkamonS · 2023-05-01T08:49:27Z

6_Backend/ToDoAPI/ToDoAPI/Controllers/ScoreController.cs

+                return BadRequest(ex.Message);
+            }
+        }
+        [HttpPost("{candidateId}/{score}/{scoreTypeDescription}")]


I think you should move the score value to FormBody

I'm still wondering what exactly I have to do. i will fix this on my implementation

6_Backend/ToDoAPI/ToDoAPI/Data/User.cs

6_Backend/ToDoAPI/ToDoAPI/Services/CandidateService.cs

6_Backend/ToDoAPI/ToDoAPI/Controllers/ScoreController.cs

ph0pz added 6 commits April 20, 2023 11:22

test commit

7eee47a

Naming Standard and DRY Concept Assignment

fe1878f

SQL assignment

e4c3e41

first Prototype

f937bae

API service first commit

219878f

CRUD Login Register

3012a71

KornkamonS reviewed May 1, 2023

View reviewed changes

fix pull request backend review #1

120d4d8