Review Backend - Poon #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KornkamonS
reviewed
May 1, 2023
| [Route("[controller]")] | ||
| public class CandidateController : ControllerBase | ||
| { | ||
| private readonly ITodoService _todoService; |
|
|
||
| } | ||
| [HttpGet("Dashboard")] | ||
| public List<UserContract> Dashboard() |
There was a problem hiding this comment.
rename the path and method to relate to the operation
| public DateTime Meet { get; set; } | ||
| [Key] | ||
| public Guid UserId { get; set; } | ||
| public User User_Appointment { get; set; } |
There was a problem hiding this comment.
Change User_Appointment to Pascal Case
| public DateTime Warn { get; set; } | ||
| [Key] | ||
| public Guid UserId { get; set; } | ||
| public User User_Notification { get; set; } |
| public string Image { get; set; } | ||
| [Key] | ||
| public Guid UserId { get; set; } | ||
| public User User_Picture { get; set; } |
| public float Evaluation { get; set; } | ||
| [Key] | ||
| public Guid UserId { get; set; } | ||
| public User User_Score { get; set; } |
| public string? File { get; set; } = null; | ||
| [Key] | ||
| public Guid UserId { get; set; } | ||
| public User User_File { get; set; } |
|
|
||
| namespace Candidate.Services | ||
| { | ||
| public interface ITodoService |
|
|
||
| namespace Candidate.Data | ||
| { | ||
| public class Picture |
There was a problem hiding this comment.
naming the class more specific such as UserPicture or add the comment
added 2 commits
May 2, 2023 23:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Candidate Project
Database
Have 5 tables --> Appointments Table, Pictures Table, Scores Table, UrlFiles Table, Users Tables
Note: Primary key is Id in Users Table references foreign key is UserId in Other Tables
Controllers
GET Method have 6 --> Dashboard, Applied, Accept, Interview, Disqualified, Hired
Note: For get data from database to render in front-end
PUT Method have 1 --> /User/{id}
Note: For update answer form by admin of each
POST Method have 1 --> CreateUser
Note: For create user and set default of data
DELETE Method have 1 --> {id}
Note: For delete data of the user of each