Review Backend - Sunny #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KornkamonS
reviewed
May 1, 2023
| [HttpGet] | ||
| public async Task<ActionResult<IEnumerable<Candidate>>> GetAllCandidate() | ||
| { | ||
| var a = await _candidateService.GetAllCandidate(); |
| _commentService = commentService; | ||
| } | ||
|
|
||
| [HttpGet("get/{CandidateId}")] |
| } | ||
|
|
||
| #region table | ||
| public DbSet<Candidate> Candidate { get; set; } |
There was a problem hiding this comment.
change to plural word for data list variable
| public string Experience { get; set; } | ||
| public string Skills { get; set; } | ||
| public string Personality { get; set; } | ||
| public string cInputDate { get; set; } |
| public int CommentId { get; set; } | ||
| public string cComment { get; set; } | ||
|
|
||
| public string cCommentDate { get; set; } |
| { | ||
| [Key] | ||
| public int CommentId { get; set; } | ||
| public string cComment { get; set; } |
There was a problem hiding this comment.
Pascal case and rename to more details or add the comment
|
|
||
| namespace ToDoAPI.Data | ||
| { | ||
| public class Commentinfo |
|
|
||
| public DbSet<User> Users { get; set; } | ||
|
|
||
| public DbSet<Commentinfo> Commentinfo { get; set; } |
| public string Password { get; set; } | ||
| } | ||
|
|
||
| public class LoginResponse |
There was a problem hiding this comment.
create new folder to separate Model and Contract class
| { | ||
| //return await _context.Candidate.Where(ci => ci.CandidateId == CandidateId).ToListAsync(); | ||
|
|
||
| var candidates = await _context.Commentinfo.Where(c => c.CandidateId == CandidateId).ToListAsync(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data
-> In the Candidate table have data CandidateId, FirstName, LastName, Email, PhoneNumber, Rating, Position, Gender, Attitude, Experience, Skills, Personality, cInputDate and cAppointment
-> In the Commentinfo table have CommentId, cComment, cCommentDate, CandidateId
-> In the User table have Id, Name, UserName, Password
Schemas
Controller
-> CandidateController have Method
-> CommentController have Method
-> User have Method
Services/Interfaces
-> CandidateServices connect with ICandidateServices
-> CommentServices connect with ICommentServices
-> UserService connect with IUserService