Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pre-commit): finalise rstcheck configuration across all formulas #267

Merged
merged 2 commits into from
Oct 10, 2020
Merged

feat(pre-commit): finalise rstcheck configuration across all formulas #267

merged 2 commits into from
Oct 10, 2020

Conversation

myii
Copy link
Owner

@myii myii commented Oct 10, 2020

Also includes:

  • refactor(contributing): centralise to use one template

myii added a commit to saltstack-formulas/.github that referenced this pull request Oct 10, 2020
@myii
docs(pre-commit): finalise rstcheck configuration
42321ec 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/apache-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
1c2125c 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/apt-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
2d520d2 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/apt-cacher-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
77f4424 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/arvados-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
9539adf 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/bind-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
800a5e1 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/cert-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
125dffb 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/chrony-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
f876619 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/collectd-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
938b8ed 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/consul-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
3bd7a05 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/cron-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
a3fa371 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/deepsea-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
6b59de0 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/devstack-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
0a2fa0e 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/dhcpd-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
52c33c9 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/django-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
e0e5b69 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/docker-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
87c737c 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/eclipse-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
8882a01 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/epel-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
8039f7c 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/exim-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
ec51349 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/fail2ban-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
24ab8f7 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/firewalld-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
118eacf 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/golang-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
e7fc872 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/grafana-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
01751a1 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/haproxy-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
0792e26 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/hostsfile-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
d6a4e2a 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/icinga2-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
ab3c855 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/influxdb-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
c80c66e 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/iptables-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
a296994 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/rkhunter-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
d5d5946 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/rng-tools-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
d0118c2 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/rspamd-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
b7bc9ee 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/salt-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
22fa616 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/sqldeveloper-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
116a8bb 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/sqlplus-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
7a8ce6e 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/strongswan-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
d88d911 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/stunnel-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
8bc4807 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/sudoers-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
0202050 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/suricata-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
35a0b47 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/sysctl-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
ba59cf8 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/syslog-ng-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
6c09627 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/sysstat-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
bf59577 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/systemd-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
389b253 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/telegraf-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
0602d2a 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/template-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
e78aa0c 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/timezone-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
d393818 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/tomcat-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
ed06e07 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/ufw-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
25b4d74 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/users-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
89c3c8f 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/varnish-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
ea962cf 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/vault-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
e42dc17 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/vim-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
b2d06e6 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/vsftpd-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
9e4584d 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/zabbix-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
c7dff99 
* Automated using myii/ssf-formula#267
@myii myii merged commit b13cf87 into master Oct 10, 2020
@myii myii deleted the feat/enable-rstcheck-across-remaining-formulas branch October 10, 2020 06:16
@myii
Copy link
Owner Author

myii commented Oct 10, 2020

🎉 This PR is included in version 1.219.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myii myii added the released label Oct 10, 2020
@myii
Copy link
Owner Author

myii commented Oct 10, 2020

@dafyddj All done, rstcheck enabled across all formulas. One interesting point, however: you'll notice that I also had to make changes to docs/TOFS_pattern.rst, since this was also triggering a violation when run directly:

deepsea-formula$ git ls-files -- '*.rst' | xargs rstcheck
docs/TOFS_pattern.rst:67: (ERROR/3) Error in "code-block" directive:

Yet not being caught when run through pre-commit. Something worth investigating, if either of us gets the chance. Would have to use an earlier commit, though, since the fix has been pushed through to all formulas using this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@myii