Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): standardise use of share suite & _mapdata state #302

Merged
merged 9 commits into from
Mar 23, 2021
Merged

feat(test): standardise use of share suite & _mapdata state #302

merged 9 commits into from
Mar 23, 2021

Conversation

myii
Copy link
Owner

@myii myii commented Mar 23, 2021 •
edited
Loading

Various objectives met with this PR:

  • Use the share suite across all formulas.
  • Use the _mapdata state across all formulas (run in CI for map.jinja dump, verification can be tackled later).
  • Centralise the Gemfile template and update kitchen-docker comment.
  • Update .rubocop.yml with regards to ExcludedMethods => IgnoredMethods.
  • Clear up the use of YAML node anchors in formulas.yaml.

Already tested these changes across all formulas (more than once), the last run being:

While pushing these changes, took this opportunity to fix the missing rubocop entry in .pre-commit-config.yaml in the following formulas (where *travis_do_not_use_single_job_for_linters was removed in #293):

  • iptables
  • syslog-ng
  • vault

@myii myii force-pushed the feat/use-share-suite-across-all-formulas branch from ac8ca71 to c7f4726 Compare March 23, 2021 19:50
@myii myii changed the title feat(test/share): use share suite across all formulas feat(test): standardise use of share suite & _mapdata state Mar 23, 2021
myii added a commit to saltstack-formulas/apache-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
e7c2d20 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/apt-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
9f6b2b1 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/apt-cacher-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
91760d6 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/arvados-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
e804dd1 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/bind-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
3cb26c0 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/cert-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
b372c37 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/chrony-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
e2d97f9 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/collectd-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
f461b84 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/consul-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
13db8f4 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/cron-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
73b9643 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/deepsea-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
babe071 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/devstack-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
628bee8 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/dhcpd-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
cf811ec 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/django-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
56cb1ec 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/docker-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
69d7e65 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/eclipse-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
17fed2f 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/epel-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
bd9b1ba 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/exim-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
96a7a85 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/fail2ban-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
920bb7d 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/redis-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
de567a6 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/rkhunter-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
47310c3 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/rng-tools-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
4a58684 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/rspamd-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
9156f44 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/salt-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
9816f47 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/sqldeveloper-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
bcba9a6 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/sqlplus-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
570d526 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/strongswan-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
b192413 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/stunnel-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
e50d418 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/sudoers-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
e58973f 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/suricata-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
64bd9cb 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/sysctl-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
96039ae 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/syslog-ng-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
9e67b07 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/sysstat-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
cbeee93 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/systemd-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
c815870 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/telegraf-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
6f2d06b 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/template-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
bbe1c78 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/timezone-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
6b98bb7 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/tomcat-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
b39bbea 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/ufw-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
43a0932 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/users-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
2a7c0de 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/varnish-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
c7bb863 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/vault-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
9877500 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/vim-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
90a3fdc 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/vsftpd-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
979bf50 
* Automated using myii/ssf-formula#302
myii added a commit to saltstack-formulas/zabbix-formula that referenced this pull request Mar 23, 2021
@myii
test: standardise use of share suite & _mapdata state [skip ci]
05eae71 
* Automated using myii/ssf-formula#302
@myii myii merged commit 0b8240f into master Mar 23, 2021
@myii myii deleted the feat/use-share-suite-across-all-formulas branch March 23, 2021 21:39
@myii
Copy link
Owner Author

myii commented Mar 23, 2021

🎉 This PR is included in version 1.254.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myii myii added the released label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@myii