Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

myokit.save() now raises a ValueError if model, protocol, and script are all None. #977

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

MichaelClerx
Copy link
Member

Closes #639.

Base automatically changed from 625-us-api to main June 7, 2023 18:43
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f986d25) 100.00% compared to head (34b9723) 100.00%.

❗ Current head 34b9723 differs from pull request most recent head 4ac0b49. Consider uploading reports for the commit 4ac0b49 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #977   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines        20661     20663    +2     
=========================================
+ Hits         20661     20663    +2     
Impacted Files Coverage Δ
myokit/_io.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MichaelClerx MichaelClerx merged commit 7781538 into main Jun 7, 2023
@MichaelClerx MichaelClerx deleted the 639-empty-save branch June 7, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make myokit.save() raise an error or a warning if no model, protocol, or script is passed in
1 participant