Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyQt6 and PySide6 support #979

Merged
merged 9 commits into from
Jun 9, 2023
Merged

Add PyQt6 and PySide6 support #979

merged 9 commits into from
Jun 9, 2023

Conversation

MichaelClerx
Copy link
Member

@MichaelClerx MichaelClerx commented Jun 7, 2023

  • IDE
  • DataLogViewer
  • DataBlockViewer

@MichaelClerx MichaelClerx changed the title PyQt6 and PySide6 support Add PyQt6 and PySide6 support Jun 7, 2023
@MichaelClerx
Copy link
Member Author

MichaelClerx commented Jun 7, 2023

Probably also a good time to drop PyQt4 and PySide support.

Wikipedia says 5 was released in 2012, and support for 4 ended in 2015. Myokit deprecated Qt4 and PySide use in september 2019.

@MichaelClerx
Copy link
Member Author

PyQt6 uses exec as a function name, which causes a syntax error in Python 2
So unless we want to have some file that renames it exec_ that we import from only on PySide6, this might have to wait until we drop Python2 ?

@MichaelClerx
Copy link
Member Author

PyQt6 uses exec as a function name, which causes a syntax error in Python 2 So unless we want to have some file that renames it exec_ that we import from only on PySide6, this might have to wait until we drop Python2 ?

Done 😁

@MichaelClerx MichaelClerx marked this pull request as ready for review June 9, 2023 15:26
@MichaelClerx MichaelClerx linked an issue Jun 9, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3b698bb) 100.00% compared to head (8f7be74) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #979   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          101       101           
  Lines        20406     20406           
=========================================
  Hits         20406     20406           
Impacted Files Coverage Δ
myokit/__init__.py 100.00% <100.00%> (ø)
myokit/_config.py 100.00% <100.00%> (ø)
myokit/_system.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MichaelClerx MichaelClerx merged commit 6f1cbcd into main Jun 9, 2023
@MichaelClerx MichaelClerx deleted the 916-qt6 branch June 9, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Qt 6 i.e. PyQt6 and PySide6
1 participant