Fixes for attachment background processing #7854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As with other config files we may need to change the configuration here for production environments.
When the hexdigest of an attachment has changed we can't retrieve the original un-masked body of attachments. This is resulting in errors, to fix this we can call `IncomingMessage#parse_raw_email!` to completely rebuild the attachments (with new hexdigest) from scratch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Changes after #7681
What does this do?
Why was this needed?
Implementation notes
When calling
parse_raw_email!(with hexdigest missing) it will result in brand newFoiAttachmentinstances with the old ones removed from the database. This means any user attempting the load the attachment might experience a temporary 404.