Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Prepared (Fixes #95, #97) #157

Merged
merged 48 commits into from
Feb 4, 2018
Merged

Redesign Prepared (Fixes #95, #97) #157

merged 48 commits into from
Feb 4, 2018

Commits on Jan 31, 2018

  1. Ditch Prepared's refcounting (it's no longer used/needed anyway) and … 

    …PreparedImpl.
    @Abscissa
    Abscissa committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    cfd18e8 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. Add exec/query overloads that take a Prepared instead of an SQL string.

    @Abscissa
    Abscissa committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    ba856de View commit details
    Browse the repository at this point in the history

  2. Minor internal Prepared cleanup: Create getExecQueryImplInfo() for DRY.

    @Abscissa
    Abscissa committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    0a69d93 View commit details
    Browse the repository at this point in the history

  3. Make Prepared.enforceNotReleased package, not private.

    @Abscissa
    Abscissa committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    ea2069a View commit details
    Browse the repository at this point in the history

  4. Move Prepared's exec/query implementations into command module's exec… 

    …/query overloads.
    @Abscissa
    Abscissa committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    9b1b4f8 View commit details
    Browse the repository at this point in the history

  5. Update exec/query docs. [ci skip]

    @Abscissa
    Abscissa committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    0fcdbba View commit details
    Browse the repository at this point in the history

  6. Move Prepared registration code out of ctor and into register/immedia… 

    …teRegister functions.
    @Abscissa
    Abscissa committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    2e809e2 View commit details
    Browse the repository at this point in the history

  7. Per-connection prepared stmt info is stored in Connection, not Prepar… 

    …ed, and indexed by sql string.
    @Abscissa
    Abscissa committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    3f9838c View commit details
    Browse the repository at this point in the history

  8. Changed Connection's statement release queue to also support register… 

    …ing, and to operate on sql strings, not ids.
    @Abscissa
    Abscissa committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    fc51978 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2018

  1. Decrease Prepared reliance on Connection.

    @Abscissa
    Abscissa committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    632e5ab View commit details
    Browse the repository at this point in the history

  2. Further reduce Prepared's reliance on Connection.

    @Abscissa
    Abscissa committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    dbc9bee View commit details
    Browse the repository at this point in the history

  3. Ditch idea of queuing statement registrations.

    @Abscissa
    Abscissa committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    f2887eb View commit details
    Browse the repository at this point in the history

  4. Create BackwardCompatPrepared to help user code migrate to v2.0.0.

    @Abscissa
    Abscissa committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    3ef8c95 View commit details
    Browse the repository at this point in the history

  5. Try migrating mysqln itself using BackwardCompatPrepared.

    @Abscissa
    Abscissa committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    60ea4b6 View commit details
    Browse the repository at this point in the history

  6. Fix for DMD 2.070 and below.

    @Abscissa
    Abscissa committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    b4ccbcc View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2018

  1. Fix compatibility version of queryRowTuple

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    db507df View commit details
    Browse the repository at this point in the history

  2. Update mysqln tests to new Prepared API.

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    d995850 View commit details
    Browse the repository at this point in the history

  3. Revive an old integration test.

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    d3a74f1 View commit details
    Browse the repository at this point in the history

  4. Better named for members of struct PreparedServerInfo

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    184be43 View commit details
    Browse the repository at this point in the history

  5. example: Use idiomatic UFCS-style.

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    e324428 View commit details
    Browse the repository at this point in the history

  6. Document the intended Prepared changes for v2.0.0. [ci skip]

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    6ba1794 View commit details
    Browse the repository at this point in the history

  7. Remove disabled code for Prepared.exec/query. [ci skip]

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    4c70e03 View commit details
    Browse the repository at this point in the history

  8. Eliminate Prepared.register, plus related cleanup.

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    4085748 View commit details
    Browse the repository at this point in the history

  9. Create public Connection.register(Prepared)

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    0e0b487 View commit details
    Browse the repository at this point in the history

  10. Rearrange some code in Prepared.

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    d544fbe View commit details
    Browse the repository at this point in the history

  11. Rename Connection.isPreparedRegistered to Connection.isRegistered

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    83449a4 View commit details
    Browse the repository at this point in the history

  12. Create overload isRegistered(Prepared)

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    332be31 View commit details
    Browse the repository at this point in the history

  13. Move Prepared.release to Connection.

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    7c52faa View commit details
    Browse the repository at this point in the history

  14. Eliminate Prepared's reference to Connection.

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    d52d4ae View commit details
    Browse the repository at this point in the history

  15. Move Prepared's low-level comms code to temporary new home in mysql.c… 

    …onnection.
    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    a81fd1d View commit details
    Browse the repository at this point in the history

  16. Eliminate mysql.prepared's dependency on mysql.connection (except whe… 

    …n compiling unittests).
    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    6e2073e View commit details
    Browse the repository at this point in the history

  17. Minor doc fix. [ci skip]

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    50fb240 View commit details
    Browse the repository at this point in the history

  18. Minor doc fix. [ci skip]

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    43a227b View commit details
    Browse the repository at this point in the history

  19. Minor doc fix (3rd try). [ci skip]

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    a02f90c View commit details
    Browse the repository at this point in the history

  20. Prepared.numArgs used to be const and still can be.

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    597717f View commit details
    Browse the repository at this point in the history

  21. Implement/test auto-register for prepared statements.

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    176847b View commit details
    Browse the repository at this point in the history

  22. Update changelog [ci skip]

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    b155e89 View commit details
    Browse the repository at this point in the history

  23. Minor changelog changes.

    @Abscissa
    Abscissa committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    a23ae73 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2018

  1. Accidentally messed up the regression test for mysql-d#154 earlier, b… 

    …y failing to update parts of it.
    @Abscissa
    Abscissa committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    cef0676 View commit details
    Browse the repository at this point in the history

  2. Add a (currently disabled) test for Prepared's ability to safely be r… 

    …efcounted during GC cycle.
    @Abscissa
    Abscissa committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    bf0ede8 View commit details
    Browse the repository at this point in the history

  3. Use preparedLookup *as* the prepared statement release queue.

    @Abscissa
    Abscissa committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    d9c1683 View commit details
    Browse the repository at this point in the history

  4. No longer using statementId==0 as a way to indicate an unregistered p… 

    …repared statement.
    @Abscissa
    Abscissa committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    3dfda0a View commit details
    Browse the repository at this point in the history

  5. Re-disable experimental RCPrepared test and update its docs.

    @Abscissa
    Abscissa committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    6744524 View commit details
    Browse the repository at this point in the history

  6. Added a little sanity check.

    @Abscissa
    Abscissa committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    52ac444 View commit details
    Browse the repository at this point in the history

  7. Fix registering a statement already queued for release, and add a few… 

    … tests.
    @Abscissa
    Abscissa committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    ec3462c View commit details
    Browse the repository at this point in the history

  8. Prune some dead imports.

    @Abscissa
    Abscissa committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    1aa49a1 View commit details
    Browse the repository at this point in the history

  9. Deprecate MYXNotPrepared.

    @Abscissa
    Abscissa committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    3c608fb View commit details
    Browse the repository at this point in the history

  10. Doc fixes/updates. [ci skip]

    @Abscissa
    Abscissa committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    ea2f79a View commit details
    Browse the repository at this point in the history