update react native projects #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrnas
commented
Sep 26, 2018
| "presets": ["babel-preset-expo"], | ||
| "env": { | ||
| "development": { | ||
| "plugins": ["transform-react-jsx-source"] |
There was a problem hiding this comment.
Had some issues with the javascript side of the project, removed this following this suggestion, maybe an update was needed instead but I assume this won't be relevant after switch to typescript.
Arrnas
commented
Sep 26, 2018
| "plugins": ["transform-react-jsx-source"] | ||
| } | ||
| } | ||
| "presets": ["module:metro-react-native-babel-preset"] |
There was a problem hiding this comment.
this might not be needed, seems to also work with babel-preset-expo
Arrnas
commented
Sep 26, 2018
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "MysterionReact", | |||
| "name": "MysteriumVPN", | |||
There was a problem hiding this comment.
Updating native projects would fail because it would look for project with the legacy name instead of the correct one.
|
It's hard to review it without react-native experience.. Does it work on android as well? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this is needed => ios project didn't work on xcode because reason
What I did => ran
react-native-git-upgradeand fixed conflicts.@donce @shroomist