Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make services' activity status saving more consistent #6066

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

Zensey
Copy link
Contributor

@Zensey Zensey commented Jul 23, 2024

Context:
Very often, when the node is restarted, the activity of services is deactivated in an arbitrary manner.
The reason is onordered and concurrent run of updateActiveServicesInUserConfig method on start of each service.

This patch orders run of updateActiveServicesInUserConfig, so that active-services property with all active servies will be written the last.

Fixes: #6055

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.50%. Comparing base (3174272) to head (e4d497a).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
tequilapi/endpoints/service.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6066      +/-   ##
==========================================
- Coverage   37.92%   28.50%   -9.43%     
==========================================
  Files         371      520     +149     
  Lines       20715    29963    +9248     
==========================================
+ Hits         7856     8540     +684     
- Misses      12075    20598    +8523     
- Partials      784      825      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zensey Zensey force-pushed the fix/active-services branch 3 times, most recently from 8fc8bf1 to 1be7013 Compare July 24, 2024 09:50
@Zensey Zensey requested review from redhatua and removed request for redhatua July 25, 2024 13:22
@Zensey Zensey changed the title Make services' activity status persistent Make services' activity status saving more consistent Jul 29, 2024
Copy link

stale bot commented Aug 15, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 15, 2024
@stale stale bot removed the stale label Aug 30, 2024
…f all services are written the last

Signed-off-by: Anton Litvinov <jnashicq@gmail.com>
@Zensey Zensey merged commit 5938d83 into master Aug 30, 2024
19 checks passed
@Zensey Zensey deleted the fix/active-services branch August 30, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Services On/off are not persistent after restart or reboot of node and device.
4 participants