Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better on-disk representations #206

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mzabani
Copy link
Owner

@mzabani mzabani commented Oct 19, 2024

  • Column order no longer in each column's rep file, but rather in the table's objrep. This makes it much easier to review PRs which change column order by e.g. rewriting a table. Effects on intentional merge conflicts still unknown, but this is a secondary concern
  • Full function definitions instead of a md5 hash of them. This should also make it easier to review PRs that make changes to existing functions.
  • Pretty print constraint definitions
  • Pretty print column types

TODO:
Modify the README to show that diffs would help review PRs changing function defnitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant