feat(iroh-resolver): create a balanced tree dag #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramfox
force-pushed
the
ramfox/balanced_tree
branch
2 times, most recently
from
ac101cd
to
d949b40
Compare
ramfox
commented
Aug 23, 2022
ramfox
commented
Aug 23, 2022
ramfox
force-pushed
the
ramfox/balanced_tree
branch
2 times, most recently
from
ae09aa0
to
660034a
Compare
ramfox
commented
Aug 23, 2022
|
tests failing because: "We cannot run this job using the selected resource class. Please check your configuration and try again."? |
Ignore mac tests for now, I have to figure it out seems like some permission issue with the runners. |
ramfox
force-pushed
the
ramfox/balanced_tree
branch
from
e795f39
to
2747871
Compare
dignifiedquire
previously approved these changes
Aug 31, 2022
ramfox
force-pushed
the
ramfox/balanced_tree
branch
from
e4555ba
to
916bc9e
Compare
ramfox
changed the title
ramfox
force-pushed
the
ramfox/balanced_tree
branch
from
916bc9e
to
66b9d5b
Compare
When adding content to iroh, create a balanced tree.
Our balanced tree implementation takes a stream of
chunks (`BytesMut`) and returns a stream of Bytes
of the encoded nodes of the dag, and their associated Cids.
`(Cid, Bytes)`
The implementation emits the node as soon as it has
been created.
All the leaves of the tree are encoded as unixfs `Raw`
nodes. All the stems & the root of the tree are encoded
as unixfs `File` nodes.
We've put effort into having our nodes be as similar to
kubo as possible, but we have intentionally differed in
a few ways:
- all of our "stem" nodes have `name: None`. In kubo, the
parents of leaf nodes have the go equivalent of
`name: Some("".to_string())`.
- the `tsize` of our links is the cumulative size of
the encoded tree associated with that link. The definition
of `tsize` seems to be unfixed, and can mean different things
depending on the implementation.
ramfox
force-pushed
the
ramfox/balanced_tree
branch
from
66b9d5b
to
e131e0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding content to iroh, create a balanced tree.
Our balanced tree implementation takes a stream of
chunks (
BytesMut) and returns a stream of Bytesof the encoded nodes of the dag, and their associated Cids.
(Cid, Bytes)The implementation emits the node as soon as it has
been created.
All the leaves of the tree are encoded as unixfs
Rawnodes. All the stems & the root of the tree are encoded
as unixfs
Filenodes.We've put effort into having our nodes be as similar to
kubo as possible, but we have intentionally differed in
a few ways:
name: None. In kubo, theparents of leaf nodes have the go equivalent of
name: Some("".to_string()).tsizeof our links is the cumulative size ofthe encoded tree associated with that link. The definition
of
tsizeseems to be unfixed, and can mean different thingsdepending on the implementation.