refactor(iroh): remove flume from iroh-cli and iroh #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this requires adding an AsyncChannelProgressSender. FlumeProgressSender will be removed as soon as all flume is gone.
The rest requires the docs flume purge PR to be merged.
Again, this is just a workaround until the same_channel thing gets merged.
rklaehn
force-pushed
the
iroh-cli-flume-purge
branch
from
243f1f6
to
313dc17
Compare
matheus23
reviewed
Jul 26, 2024
matheus23
reviewed
Jul 26, 2024
matheus23
reviewed
Jul 26, 2024
matheus23
reviewed
Jul 26, 2024
matheus23
reviewed
Jul 26, 2024
|
Is this the last flume purge PR? |
I wish. We still got flume in iroh-blobs and quic-rpc... These three were the easy ones... |
Co-authored-by: Philipp Krüger <philipp.krueger1@gmail.com>
Co-authored-by: Philipp Krüger <philipp.krueger1@gmail.com>
Co-authored-by: Philipp Krüger <philipp.krueger1@gmail.com>
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2543/docs/iroh/ Last updated: 2024-08-02T03:37:03Z |
Co-authored-by: Philipp Krüger <philipp.krueger1@gmail.com>
Co-authored-by: Philipp Krüger <philipp.krueger1@gmail.com>
matheus23
approved these changes
Aug 2, 2024
matheus23
added a commit
that referenced
this pull request
Nov 14, 2024
## Description refactor(iroh): remove flume from iroh-cli and iroh Removes most usages of flume from iroh and all usages of flume from iroh-cli. ## Breaking Changes None ## Notes & open questions Note: this does not remove all usages because we need the iroh docs purge PR to be merged before that. ## Change checklist - [ ] Self-review. - [ ] ~~Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - [ ] ~~Tests if relevant.~~ - [ ] ~~All breaking changes documented.~~ --------- Co-authored-by: Philipp Krüger <philipp.krueger1@gmail.com> Co-authored-by: Kasey <kasey@n0.computer> Co-authored-by: Kasey Huizinga <ramfox@Kaseys-MBP.lan>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor(iroh): remove flume from iroh-cli and iroh
Removes most usages of flume from iroh and all usages of flume from iroh-cli.
Breaking Changes
None
Notes & open questions
Note: this does not remove all usages because we need the iroh docs purge PR to be merged before that.
Change checklist
Documentation updates following the style guide, if relevant.Tests if relevant.All breaking changes documented.