test(iroh-cli): reduce flakyness of cli_provide_file_resume

[divagant-martian]

Description

In windows there is no way to copy a file being accessed by another process in an accessible way. This is what makes this test fail since it attempt to copy the blobs.db folder a couple of times while the iroh instance that handles is running.

The change is simple: shutdown the provider, copy the files, re-start the provider. From my perspective, this does not affect what the test is attempting to assert.

Now, since this includes re-starting the iroh instance that provides the files several times, and we match on output, sometimes we can get weird logs related to shutdown. One of those (and the only one I have seen so far) is for a netcheck report and didn't finish on time. Instead of logging this in the reportgen actor, the error is bubbled up to be handled by the netcheck actor (which will have shutdown by then) thus reducing noise and allowing for better error handling in the future

Breaking Changes

n/a

Notes & open questions

n/a

Change checklist

• Self-review.
• Documentation updates following the style guide, if relevant.
• Tests if relevant.
• All breaking changes documented.

[github-actions]

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2563/docs/iroh/

Last updated: 2024-07-29T19:01:47Z

[dignifiedquire]

less flaky tests make me happy, one small nit

[divagant-martian]

while I had to re-add the flaky mark since one of the windows worflows failed, I think it's still an improvement: the test is now flaky instead of failing 100% of the time. Addressed your nit and if it's ok I'll merge and we can keep looking into the new kinds of failures in later antiflaky attempts