refactor(iroh-net): Various logging improvements #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Attach the spans when spawning the local-swarm-discovery. We should always use .instrument() when spawning. - Clearly log the start and end of connection establishment. - In the events.net.* events always use remote_node when showing the NodeId of the remote node. These were introduced before we settled on the "remote node" terminology, now it makes more sense to double down on this as it makes the logs clearer.
flub
commented
Sep 23, 2024
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2744/docs/iroh/ Last updated: 2024-09-23T21:35:48Z |
divagant-martian
approved these changes
Sep 23, 2024
oh yes, clever move. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attach the spans when spawning the local-swarm-discovery. We should
always use .instrument() when spawning.
Clearly log the start and end of connection establishment.
In the events.net.* events always use remote_node when showing the
NodeId of the remote node. These were introduced before we settled
on the "remote node" terminology, now it makes more sense to double
down on this as it makes the logs clearer.
Breaking Changes
None, events.net is not considered part of the public API.
Notes & open questions
Change checklist
[ ] Documentation updates following the style guide, if relevant.[ ] Tests if relevant.[ ] All breaking changes documented.