Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iroh): disable docs by default #2748

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

dignifiedquire
Copy link
Contributor

Breaking Changes

  • removed: iroh::node::Builder::disable_docs
  • added: iroh::node::Builder::enable_docs
  • by default iroh::node::Node::memory & persistent have docs disabled

@dignifiedquire dignifiedquire self-assigned this Sep 25, 2024
@dignifiedquire dignifiedquire added this to the v0.26.0 milestone Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2748/docs/iroh/

Last updated: 2024-09-30T08:37:12Z

Copy link
Contributor

@ramfox ramfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iroh/examples/client.rs needs to be updated too

## Breaking Changes

- removed: `iroh::node::Builder::disable_docs`
- added: `iroh::node::Builder::enable_docs`
- by default `iroh::node::Node::memory` & `persistent` have docs disabled
Copy link

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: b3ee5ac

@dignifiedquire dignifiedquire added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit eb4c4a6 Sep 30, 2024
25 of 27 checks passed
@dignifiedquire dignifiedquire deleted the feat-disable-docs-by-default branch September 30, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants