fix(ci): netsim does not interact with PR comments on forks #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2777/docs/iroh/ Last updated: 2024-10-04T10:37:07Z |
divagant-martian
approved these changes
Oct 15, 2024
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description Seems like permissions are still messy and the netsim job fails on forks whenever it interacts with a PR from a fork, even though it's on our own repo and we allow it to run. This simply drops any type of commenting on the PR from a fork. Need to add back the required check for this job once it's merged. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems like permissions are still messy and the netsim job fails on forks whenever it interacts with a PR from a fork, even though it's on our own repo and we allow it to run.
This simply drops any type of commenting on the PR from a fork.
Need to add back the required check for this job once it's merged.
Breaking Changes
Notes & open questions
Change checklist