Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(iroh-net): Optimise present nodes in ActiveRelay #2781

Merged
merged 9 commits into from
Oct 3, 2024
Merged

refactor(iroh-net): Optimise present nodes in ActiveRelay #2781

merged 9 commits into from
Oct 3, 2024

Commits on Oct 3, 2024

  1. refactor(iroh-net): Keep connection name, remove connection count 

    These are two cleanups in the relay client:

- The `relay::Client` hands out a connection object when asked to
  connect.  This `Conn` was imported with rename to `RelayClient`
  which was a bit confusing as this was already the relay client.  It
  is now renamed to `RelayConn` which makes a lot more sense.  The
  related builder struct etc are renamed to match.

- The `relay::Client` had a counter for the number of connections made
  to the relay.  That seems fun, but was entirely unused.  If this is
  a useful thing to have it should probably be a counter metric
  instead but let's not add anything that no one is using.  Removing
  this makes a lot of APIs a bit simpler and removes some state
  tracking.
    @flub
    flub committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    544b933 View commit details
    Browse the repository at this point in the history

  2. small doc fixup

    @flub
    flub committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b1ea4b2 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Divma <26765164+divagant-martian@users.noreply.github.com>
    @flub @divagant-martian
    flub and divagant-martian authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    62c7421 View commit details
    Browse the repository at this point in the history

  4. fixup some more names

    @flub
    flub committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    60ebe40 View commit details
    Browse the repository at this point in the history

  5. don't rename anything

    @flub
    flub committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b38cf2f View commit details
    Browse the repository at this point in the history

  6. docs style

    @flub
    flub committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a22c2d3 View commit details
    Browse the repository at this point in the history

  7. Rename more variables to be consistent

    @flub
    flub committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b344622 View commit details
    Browse the repository at this point in the history

  8. refactor(iroh-net): Optimise present nodes in ActiveRelay 

    The ActiveRelay actor keeps track of which remote nodes are present
on the relay connection so that we can optimise relay connections to
remote nodes.  This does two main optimisations:

- There were two sets of these nodes kept, they could easily be
  unified.

- The set is best stored in a BTreeSet since they are simple
  NodeIds stored in them.

- Bonus: rename peer to node to match our naming convention.

- Bonus: identify nodes by NodeId since this is a routing key here.
    @flub
    flub committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    4c6e223 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review 

    Co-authored-by: Divma <26765164+divagant-martian@users.noreply.github.com>
    @flub @divagant-martian
    flub and divagant-martian committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    275b399 View commit details
    Browse the repository at this point in the history