-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow Raw
as UnixfsType
#327
Conversation
Acknowledges that a `raw` node is a valid `UnixfsNode` and therefore can be resolved as a file in the gateway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
@ramfox I don't think this is quite correct. IPLD Raw is something else than Unixfs Raw. We shouldn't treat them the same. Asfaiu the current kubo gateway allows unixfs paths -> other ipld blocks which is likely why it works on their side. If we start allowing for that we should explicitly resolve IPLD, not treat IPLD as unixfs |
Okay great, thank you. I had a feeling this was off so I wrote up an alternative way of doing this here. But I'm also woefully ignorant of the way the gateway should ideally operate. Before this PR, the path to get to the bug was this: So the problem is either:
|
Technically the Not sure whether we can correctly "detect" this state, but given we can return |
Acknowledges that a
raw
node is a validUnixfsNode
and therefore can be resolved as a file in the gatewaycloses n0-computer/beetle#148