crates.io release prep #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
release-prep
branch
2 times, most recently
from
32bdb69 to
691db62
Compare
dignifiedquire
force-pushed
the
release-prep
branch
from
691db62 to
0dab051
Compare
b5
reviewed
Nov 28, 2022
RELEASE.md
Outdated
Comment on lines
27
to
39
| Publishing on crates.io, bumping version & generating tags is done using [`cargo-release`](https://github.com/crate-ci/cargo-release). | ||
|
|
||
| Dry run | ||
|
|
||
| ```sh | ||
| $ cargo release <patch|minor|major> | ||
| ``` | ||
|
|
||
| Actual publishing | ||
|
|
||
| ```sh | ||
| $ cargo release --execute <patch|minor|major> | ||
| ``` |
There was a problem hiding this comment.
I'm assuming this requires special credentials? Should be noted if so.
b5
reviewed
Nov 28, 2022
Comment on lines
+19
to
+22
| iroh-car = { version = "0.1.1", path = "../iroh-car" } | ||
| iroh-resolver = { version = "0.1.1", path = "../iroh-resolver" } | ||
| iroh-rpc-client = { version = "0.1.1", path = "../iroh-rpc-client" } | ||
| iroh-util = { version = "0.1.1", path = "../iroh-util" } |
There was a problem hiding this comment.
aren't we doing "0.1.2", or is this an artifact of being the first release?
There was a problem hiding this comment.
this is just noting the current version, not the new one
b5
reviewed
Nov 28, 2022
Comment on lines
+3
to
+6
| [](https://crates.io/crates/iroh-api) | ||
| [](https://docs.rs/iroh-api) | ||
| [](../LICENSE-MIT) | ||
| [](https://github.com/n0-computer/iroh/actions?query=workflow%3A%22Continuous+integration%22) |
There was a problem hiding this comment.
can confirm these links actually work 😄
b5
approved these changes
Nov 28, 2022
This was referenced Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo-releaseREADME.mds