-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to rustls@0.23 #11
Conversation
Use rustls::pki_types::TrustAnchor instead.
We can't share the ClientConfig anymore as reqwest has yet to be updated to rustls@0.22 so instead we just let the client use it's own rustls configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but please make sure to do some manual testing
@dignifiedquire Good call! I only found this bug after trying to deploy the Again, good call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
please document somewhere that this uses the ring backend only for rustls |
Eh - comments loaded late. |
Opened #13 |
@flub, @dignifiedquire and @matheus23 - thanks a lot for landing this! I've taken it for a spin and it seems to be working well, could I trouble you for a Cheers 🚀 |
Haha yeah I'm hoping we can get a release out today, too. We need this as well. |
@tmpfs we've released version 0.4.0 :) 🎉 |
Thanks @matheus23 for the heads up, this has unblocked me so much appreciated 🙏 |
This upgrades the dependencies to work with Rustls 0.23
Part of n0-computer/iroh#2273