* replace all usages to prop AllAfterInTrackingOrParsed with `AllPa…

…rsed`, partial revert b81b64a

* rename prop `AllAfter` to `AllAfterInTrackingOrParsed`
* rename prop `Existing` to `ExistingInTracking`
@ SaverChangeSet.cs

* move entity class `ThreadMissingFirstReply` & `ReplySignature` into nested namespace `Related`
@ crawler

* mark prop `ImageId` as `virtual` to prevent shadowing prop with the same name in nested class `AsKey` @ EntityWithImageId.cs
@ shared
@ c#

c#/crawler/src/Db/Post/ReplySignature.cs → c#/crawler/src/Db/Post/Related/ReplySignature.cs

@@ -1,5 +1,5 @@
 // ReSharper disable PropertyCanBeMadeInitOnly.Global
-namespace tbm.Crawler.Db.Post;
+namespace tbm.Crawler.Db.Post.Related;
 
 public class ReplySignature : RowVersionedEntity
 {

c#/crawler/src/Db/Post/ThreadMissingFirstReply.cs → c#/crawler/src/Db/Post/Related/ThreadMissingFirstReply.cs

@@ -1,5 +1,5 @@
 // ReSharper disable PropertyCanBeMadeInitOnly.Global
-namespace tbm.Crawler.Db.Post;
+namespace tbm.Crawler.Db.Post.Related;
 
 public class ThreadMissingFirstReply : RowVersionedEntity
 {

c#/crawler/src/GlobalUsings.cs

@@ -35,6 +35,7 @@
 global using tbm.Crawler.Db;
 global using tbm.Crawler.Db.Post;
 global using tbm.Crawler.Db.Post.PostContent;
+global using tbm.Crawler.Db.Post.Related;
 global using tbm.Crawler.Db.Revision;
 global using tbm.Crawler.Db.Revision.Splitting;
 global using tbm.Crawler.Tieba;

c#/crawler/src/Tieba/Crawl/CrawlPost.cs

@@ -43,7 +43,7 @@ public async Task<SavedThreadsList> CrawlThreads
             if (currentPageChangeSet != null)
             {
                 savedThreads.Add(currentPageChangeSet);
-                var threadsLatestReplyPostedAt = currentPageChangeSet.AllAfter
+                var threadsLatestReplyPostedAt = currentPageChangeSet.AllParsed
                     .Select(th => th.LatestReplyPostedAt).ToList();
                 minLatestReplyPostedAt = threadsLatestReplyPostedAt.Min();
                 if (crawlingPage == 1)
@@ -76,7 +76,7 @@ public async Task<SavedRepliesKeyByTid> CrawlReplies
             .Aggregate(new HashSet<Tid>(), (shouldCrawl, threads) =>
             {
                 shouldCrawl.UnionWith(threads.NewlyAdded.Select(th => th.Tid));
-                shouldCrawl.UnionWith(threads.Existing
+                shouldCrawl.UnionWith(threads.ExistingInTracking
                     .Where(t => t.Before.ReplyCount != t.After.ReplyCount
                         || t.Before.LatestReplyPostedAt != t.After.LatestReplyPostedAt
                         || t.Before.LatestReplierId != t.After.LatestReplierId)
@@ -108,7 +108,7 @@ public async Task CrawlSubReplies(
                 var (tid, replies) = pair;
                 shouldCrawl.UnionWith(replies.NewlyAdded
                     .Where(r => r.SubReplyCount != null).Select(r => (tid, r.Pid)));
-                shouldCrawl.UnionWith(replies.Existing.Where(t =>
+                shouldCrawl.UnionWith(replies.ExistingInTracking.Where(t =>
                 {
                     var (before, after) = t;
                     return after.SubReplyCount != null && before.SubReplyCount != after.SubReplyCount;

c#/crawler/src/Tieba/Crawl/Saver/SaverChangeSet.cs

@@ -8,7 +8,7 @@ public class SaverChangeSet<TPostEntity, TParsedPost>(
     where TPostEntity : IPost
     where TParsedPost : TPostEntity, IPost.IParsed
 {
-    public IReadOnlyCollection<(TPostEntity Before, TPostEntity After)> Existing { get; } = existingBefore
+    public IReadOnlyCollection<(TPostEntity Before, TPostEntity After)> ExistingInTracking { get; } = existingBefore
         .OrderBy(postIdSelector)
         .EquiZip(existingAfter
                 .IntersectBy(existingBefore.Select(postIdSelector), postIdSelector)
@@ -21,7 +21,7 @@ public class SaverChangeSet<TPostEntity, TParsedPost>(
         .ToList().AsReadOnly();
 
     // https://stackoverflow.com/questions/3404975/left-outer-join-in-linq/23558389#23558389
-    public IReadOnlyCollection<TPostEntity> AllAfter { get; } = (
+    public IReadOnlyCollection<TPostEntity> AllAfterInTrackingOrParsed { get; } = (
         from notTracked in parsed
         join inTracking in existingAfter
             on postIdSelector(notTracked) equals postIdSelector(inTracking) into inTrackings

c#/crawler/src/Worker/ArchiveCrawlWorker.cs

@@ -64,14 +64,14 @@ string GetHumanizedElapsedTimeThenRestart()
             if (cancellationToken.IsCancellationRequested) return;
             var savedThreads = await CrawlThreads((Page)page, _forumName, _fid, cancellationToken);
             if (savedThreads == null) return;
-            var savedThreadCount = savedThreads.AllAfter.Count;
+            var savedThreadCount = savedThreads.AllParsed.Count;
             logger.LogInformation("Archive for {} threads in the page {} of forum {} finished after {:F2}s",
                 savedThreadCount, page, _forumName, GetHumanizedElapsedTimeThenRestart());
             _ = Interlocked.Add(ref totalSavedThreadCount, savedThreadCount);
 
             if (cancellationToken.IsCancellationRequested) return;
             var savedReplies = await CrawlReplies(savedThreads, _fid, cancellationToken);
-            var savedReplyCount = savedReplies.Sum(pair => pair.Value.AllAfter.Count);
+            var savedReplyCount = savedReplies.Sum(pair => pair.Value.AllParsed.Count);
             logger.LogInformation("Archive for {} replies within {} threads in the page {} of forum {} finished after {:F2}s",
                 savedReplyCount, savedThreadCount, page, _forumName, GetHumanizedElapsedTimeThenRestart());
             _ = Interlocked.Add(ref totalSavedReplyCount, savedReplyCount);
@@ -143,7 +143,7 @@ private async Task<SavedRepliesKeyByTid> CrawlReplies
         // we choose TO crawl these rare thread's replies for archive since most thread will have replies
         // following sql can figure out existing replies that not matched with parent thread's subReplyNum in db:
         // SELECT COUNT(*) FROM tbmc_f{fid}_thread AS T INNER JOIN tbmc_f{fid}_reply AS R ON T.tid = R.tid AND T.replyNum IS NULL
-        await Task.WhenAll(savedThreads.AllAfter.Select(th => th.Tid).Distinct().Select(async tid =>
+        await Task.WhenAll(savedThreads.AllParsed.Select(th => th.Tid).Distinct().Select(async tid =>
         {
             if (stoppingToken.IsCancellationRequested) return;
             await using var facadeFactory = replyCrawlFacadeFactory();
@@ -165,7 +165,7 @@ private async Task<int> CrawlSubReplies
             // we choose NOT TO crawl these rare reply's sub replies for archive since most reply won't have sub replies
             // following sql can figure out existing sub replies that not matched with parent reply's SubReplyCount in db:
             // SELECT COUNT(*) FROM tbmc_f{fid}_reply AS R INNER JOIN tbmc_f{fid}_subReply AS SR ON R.pid = SR.pid AND R.subReplyCount IS NULL
-            shouldCrawl.UnionWith(replies.AllAfter
+            shouldCrawl.UnionWith(replies.AllParsed
                 .Where(r => r.SubReplyCount != null).Select(r => (tid, r.Pid)));
             return shouldCrawl;
         });
@@ -178,7 +178,7 @@ await Task.WhenAll(shouldCrawlParentPosts.Select(async t =>
             var saved = (await facadeFactory.Value(fid, tid, pid)
                 .CrawlPageRange(1, stoppingToken: stoppingToken)).SaveCrawled(stoppingToken);
             if (saved == null) return;
-            _ = Interlocked.Add(ref savedSubReplyCount, saved.AllAfter.Count);
+            _ = Interlocked.Add(ref savedSubReplyCount, saved.AllParsed.Count);
         }));
         return savedSubReplyCount;
     }

c#/shared/src/Db/EntityWithImageId.cs

@@ -5,10 +5,10 @@ namespace tbm.Shared.Db;
 
 public abstract class EntityWithImageId : RowVersionedEntity
 {
-    public uint ImageId { get; set; }
+    public virtual uint ImageId { get; set; }
 
     public abstract class AsKey : EntityWithImageId
     {
-        [Key] public new uint ImageId { get; set; }
+        [Key] public override uint ImageId { get; set; }
     }
 }