Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(core): check errors recursively if they are originally GraphQLError #1571

Merged
merged 2 commits into from
Oct 27, 2022
Merged

enhance(core): check errors recursively if they are originally GraphQLError #1571

merged 2 commits into from
Oct 27, 2022

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Oct 27, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 13b19b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@envelop/core Patch
@envelop/sentry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan ardatan requested review from n1ru4l and saihaj and removed request for n1ru4l October 27, 2022 09:28
@ardatan ardatan assigned kamilkisiela and unassigned kamilkisiela Oct 27, 2022
@theguild-bot
Copy link
Collaborator

theguild-bot commented Oct 27, 2022 •
edited
Loading

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 626296      ✗ 0     
     data_received......................................: 2.4 GB  16 MB/s
     data_sent..........................................: 136 MB  908 kB/s
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.68µs  min=700ns    med=1.3µs   max=12.01ms p(90)=2µs     p(95)=2.4µs  
     http_req_connecting................................: avg=262ns   min=0s       med=0s      max=8.04ms  p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=4.43ms  min=190.7µs  med=2.8ms   max=76.75ms p(90)=9.73ms  p(95)=15.31ms
       { expected_response:true }.......................: avg=4.43ms  min=190.7µs  med=2.8ms   max=76.75ms p(90)=9.73ms  p(95)=15.31ms
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=3.55ms  min=402.5µs  med=2.78ms  max=36.87ms p(90)=5.78ms  p(95)=6.88ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=2.51ms  min=190.7µs  med=1.86ms  max=34.79ms p(90)=5.05ms  p(95)=8.87ms 
     ✓ { mode:envelop-just-cache }......................: avg=3.61ms  min=366.9µs  med=2.77ms  max=41.41ms p(90)=5.85ms  p(95)=7.48ms 
     ✓ { mode:graphql-js }..............................: avg=7.04ms  min=751.11µs med=5.5ms   max=58.46ms p(90)=11.3ms  p(95)=12.67ms
     ✓ { mode:prom-tracing }............................: avg=18.15ms min=2.03ms   med=16.24ms max=76.75ms p(90)=31.34ms p(95)=32.74ms
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 313148
     http_req_receiving.................................: avg=48.38µs min=12.6µs   med=22.6µs  max=28.97ms p(90)=31.5µs  p(95)=39µs   
     http_req_sending...................................: avg=37.06µs min=4.8µs    med=7.9µs   max=24.57ms p(90)=14.7µs  p(95)=22.2µs 
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=4.34ms  min=151.7µs  med=2.76ms  max=76.72ms p(90)=9.37ms  p(95)=15.11ms
     http_reqs..........................................: 313148  2087.558857/s
     iteration_duration.................................: avg=4.78ms  min=405.8µs  med=3.07ms  max=77.02ms p(90)=10.46ms p(95)=15.86ms
     iterations.........................................: 313148  2087.558857/s
     vus................................................: 0       min=0         max=10  
     vus_max............................................: 20      min=20        max=20

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2022 •
edited
Loading

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/core 3.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/apollo-datasources 2.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/apollo-federation 3.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/apollo-server-errors 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/apollo-tracing 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/auth0 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/dataloader 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/depth-limit 2.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/disable-introspection 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/execute-subscription-event 3.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/extended-validation 2.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/filter-operation-type 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/fragment-arguments 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/generic-auth 5.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/graphql-jit 5.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/graphql-middleware 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/graphql-modules 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/immediate-introspection 1.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/live-query 5.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/newrelic 5.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/on-resolve 2.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/opentelemetry 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/operation-field-permissions 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/parser-cache 5.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/persisted-operations 5.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/preload-assets 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/prometheus 7.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/rate-limiter 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/resource-limitations 3.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/response-cache 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/response-cache-redis 2.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/sentry 4.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/statsd 3.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/validation-cache 5.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎
@envelop/testing 5.0.3-alpha-20221027132110-3afc1d01 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2022 •
edited
Loading

🚀 Website Preview

The latest changes to the website are available as preview in: https://d2a44a74.envelop.pages.dev

@ardatan ardatan requested a review from saihaj October 27, 2022 13:18
@ardatan ardatan merged commit 6b48ef9 into main Oct 27, 2022
@ardatan ardatan deleted the mask-error-original branch October 27, 2022 22:23
@github-actions github-actions bot mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1ru4l n1ru4l n1ru4l approved these changes

@kamilkisiela kamilkisiela Awaiting requested review from kamilkisiela

@saihaj saihaj Awaiting requested review from saihaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ardatan @theguild-bot @n1ru4l @saihaj @kamilkisiela