Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revamp sentry plugin #1583

Merged
merged 8 commits into from
Nov 28, 2022
Merged

feat: revamp sentry plugin #1583

merged 8 commits into from
Nov 28, 2022

Conversation

n1ru4l
Copy link
Owner

@n1ru4l n1ru4l commented Nov 22, 2022

  • Remove resolver wrapping legacy API (breaking change)
  • Add tests for ensuring functionality

Closes #1570
Closes #1568
Closes #1567

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2022

🦋 Changeset detected

Latest commit: 7aedc91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/sentry Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://215a5add.envelop.pages.dev

@theguild-bot
Copy link
Collaborator

theguild-bot commented Nov 22, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 571908      ✗ 0     
     data_received......................................: 2.2 GB  15 MB/s
     data_sent..........................................: 124 MB  829 kB/s
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.61µs  min=700ns    med=1.4µs   max=8.82ms  p(90)=2.2µs   p(95)=2.7µs  
     http_req_connecting................................: avg=220ns   min=0s       med=0s      max=4.85ms  p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=4.88ms  min=192.5µs  med=3.46ms  max=88.07ms p(90)=10.42ms p(95)=16.4ms 
       { expected_response:true }.......................: avg=4.88ms  min=192.5µs  med=3.46ms  max=88.07ms p(90)=10.42ms p(95)=16.4ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=4.03ms  min=387.5µs  med=3.49ms  max=40.86ms p(90)=6.75ms  p(95)=8.19ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=2.62ms  min=192.5µs  med=1.97ms  max=27.84ms p(90)=5.02ms  p(95)=8.33ms 
     ✓ { mode:envelop-just-cache }......................: avg=4.18ms  min=410.6µs  med=3.49ms  max=56.13ms p(90)=7.11ms  p(95)=8.65ms 
     ✓ { mode:graphql-js }..............................: avg=7.86ms  min=829.01µs med=6.56ms  max=72.73ms p(90)=12.78ms p(95)=14.71ms
     ✓ { mode:prom-tracing }............................: avg=19.17ms min=2.2ms    med=16.96ms max=88.07ms p(90)=32.08ms p(95)=34.19ms
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 285954
     http_req_receiving.................................: avg=52.68µs min=12.7µs   med=23.9µs  max=28.61ms p(90)=38.3µs  p(95)=46µs   
     http_req_sending...................................: avg=39.64µs min=5.1µs    med=8.5µs   max=23.4ms  p(90)=15.9µs  p(95)=24.29µs
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=4.78ms  min=152.9µs  med=3.41ms  max=88.04ms p(90)=10.1ms  p(95)=16.31ms
     http_reqs..........................................: 285954  1906.179908/s
     iteration_duration.................................: avg=5.23ms  min=408.6µs  med=3.72ms  max=88.58ms p(90)=11.01ms p(95)=16.78ms
     iterations.........................................: 285954  1906.179908/s
     vus................................................: 5       min=5         max=19  
     vus_max............................................: 20      min=20        max=20  

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/sentry 5.0.0-alpha-20221124161914-24cce7d7 npm ↗︎ unpkg ↗︎

@n1ru4l n1ru4l force-pushed the feat-sentry-revamp branch from fcb09f6 to aafa859 Compare November 24, 2022 16:14
@n1ru4l n1ru4l merged commit f6361e8 into main Nov 28, 2022
@n1ru4l n1ru4l deleted the feat-sentry-revamp branch November 28, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sentry]: Error on skipped transactions
3 participants