Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document parsing cache optimizations #1728

Merged
merged 2 commits into from
May 16, 2023
Merged

Document parsing cache optimizations #1728

merged 2 commits into from
May 16, 2023

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Feb 20, 2023

No description provided.

@ardatan ardatan requested a review from n1ru4l February 20, 2023 17:57
@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 41d3af6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@envelop/core Patch
@envelop/apollo-federation Patch
@envelop/graphql-jit Patch
@envelop/newrelic Patch
@envelop/opentelemetry Patch
@envelop/response-cache Patch
@envelop/sentry Patch
@envelop/validation-cache Patch
@envelop/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2023 •
edited
Loading

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/core 3.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/apollo-datasources 2.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/apollo-federation 3.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/apollo-server-errors 4.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/apollo-tracing 4.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/auth0 4.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/dataloader 4.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/depth-limit 2.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/disable-introspection 4.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/execute-subscription-event 3.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/extended-validation 2.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/filter-operation-type 4.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/fragment-arguments 4.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/generic-auth 5.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/graphql-jit 5.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/graphql-middleware 4.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/graphql-modules 4.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/immediate-introspection 1.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/live-query 5.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/newrelic 5.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/on-resolve 2.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/opentelemetry 4.1.1-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/operation-field-permissions 4.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/parser-cache 5.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/persisted-operations 5.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/preload-assets 4.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/prometheus 7.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/rate-limiter 4.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/resource-limitations 3.0.8-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/response-cache 4.0.9-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/response-cache-redis 2.0.9-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/sentry 5.1.2-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/statsd 3.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/validation-cache 5.1.4-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎
@envelop/testing 5.0.7-alpha-20230505100045-41d3af63 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2023 •
edited
Loading

💻 Website Preview

The latest changes are available as preview in: https://49075420.envelop.pages.dev

@theguild-bot
Copy link
Collaborator

theguild-bot commented Feb 20, 2023 •
edited
Loading

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 643814      ✗ 0     
     data_received......................................: 2.5 GB  16 MB/s
     data_sent..........................................: 140 MB  933 kB/s
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.04µs  min=600ns    med=1.1µs   max=12.01ms  p(90)=1.7µs   p(95)=2.1µs  
     http_req_connecting................................: avg=268ns   min=0s       med=0s      max=7.74ms   p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=4.35ms  min=162.19µs med=3.22ms  max=100ms    p(90)=8.92ms  p(95)=15.15ms
       { expected_response:true }.......................: avg=4.35ms  min=162.19µs med=3.22ms  max=100ms    p(90)=8.92ms  p(95)=15.15ms
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=3.8ms   min=388.49µs med=3.4ms   max=39.09ms  p(90)=6.09ms  p(95)=7.33ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=2.23ms  min=162.19µs med=1.68ms  max=32.17ms  p(90)=4.07ms  p(95)=7.17ms 
     ✓ { mode:envelop-just-cache }......................: avg=3.86ms  min=374.09µs med=3.37ms  max=80.92ms  p(90)=6.28ms  p(95)=7.66ms 
     ✓ { mode:graphql-js }..............................: avg=6.54ms  min=704.29µs med=5.57ms  max=72.14ms  p(90)=10.68ms p(95)=12.23ms
     ✓ { mode:prom-tracing }............................: avg=18.09ms min=2.55ms   med=16.12ms max=100ms    p(90)=31.15ms p(95)=32.4ms 
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 321907
     http_req_receiving.................................: avg=40.26µs min=11.2µs   med=17.89µs max=22.36ms  p(90)=26.5µs  p(95)=33.3µs 
     http_req_sending...................................: avg=30.59µs min=3.8µs    med=6.5µs   max=23.69ms  p(90)=12.19µs p(95)=17.2µs 
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=4.28ms  min=133.19µs med=3.17ms  max=99.22ms  p(90)=8.63ms  p(95)=15.09ms
     http_reqs..........................................: 321907  2145.884579/s
     iteration_duration.................................: avg=4.65ms  min=357.79µs med=3.51ms  max=108.14ms p(90)=9.56ms  p(95)=15.48ms
     iterations.........................................: 321907  2145.884579/s
     vus................................................: 10      min=10        max=20  
     vus_max............................................: 20      min=20        max=20

@n1ru4l n1ru4l self-requested a review May 3, 2023 12:33
n1ru4l
n1ru4l requested changes May 3, 2023
View reviewed changes
Copy link
Owner

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ardatan Can you please rebase ;(or if no longer relevant close) this PR 😇

@ardatan ardatan force-pushed the get-document-stringooo branch 2 times, most recently from 6aec27e to 8ff5ea1 Compare May 5, 2023 09:52
@ardatan
Copy link
Collaborator Author

ardatan commented May 5, 2023

@n1ru4l Done!

@ardatan ardatan requested a review from n1ru4l May 5, 2023 09:53
@ardatan ardatan force-pushed the get-document-stringooo branch from 0982703 to 2dc6c6f Compare May 5, 2023 09:56
@n1ru4l n1ru4l merged commit a36925c into main May 16, 2023
@n1ru4l n1ru4l deleted the get-document-stringooo branch May 16, 2023 11:31
@theguild-bot theguild-bot mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1ru4l n1ru4l n1ru4l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ardatan @theguild-bot @n1ru4l