Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Node 14 and require Node 16 or higher #1776

Merged
merged 9 commits into from
May 22, 2023
Merged

Drop Node 14 and require Node 16 or higher #1776

merged 9 commits into from
May 22, 2023

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented May 22, 2023

No description provided.

@ardatan ardatan requested a review from n1ru4l May 22, 2023 14:13
@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: c4d816f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@envelop/extended-validation Major
@envelop/live-query Major
@envelop/resource-limitations Major
@envelop/response-cache Major
@envelop/testing Major
@envelop/core Major
@envelop/apollo-datasources Major
@envelop/apollo-federation Major
@envelop/apollo-server-errors Major
@envelop/apollo-tracing Major
@envelop/auth0 Major
@envelop/dataloader Major
@envelop/depth-limit Major
@envelop/disable-introspection Major
@envelop/execute-subscription-event Major
@envelop/filter-operation-type Major
@envelop/fragment-arguments Major
@envelop/generic-auth Major
@envelop/graphql-jit Major
@envelop/graphql-middleware Major
@envelop/graphql-modules Major
@envelop/immediate-introspection Major
@envelop/newrelic Major
@envelop/on-resolve Major
@envelop/opentelemetry Major
@envelop/operation-field-permissions Major
@envelop/parser-cache Major
@envelop/persisted-operations Major
@envelop/preload-assets Major
@envelop/prometheus Major
@envelop/rate-limiter Major
@envelop/response-cache-redis Major
@envelop/sentry Major
@envelop/statsd Major
@envelop/validation-cache Major
@envelop/types Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theguild-bot
Copy link
Collaborator

theguild-bot commented May 22, 2023 •
edited
Loading

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 575466     ✗ 0     
     data_received......................................: 2.2 GB  15 MB/s
     data_sent..........................................: 125 MB  834 kB/s
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.14µs  min=700ns    med=1.4µs   max=10.86ms p(90)=2µs     p(95)=2.4µs  
     http_req_connecting................................: avg=274ns   min=0s       med=0s      max=4.92ms  p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=4.86ms  min=195.7µs  med=3.58ms  max=81.35ms p(90)=10.25ms p(95)=16.24ms
       { expected_response:true }.......................: avg=4.86ms  min=195.7µs  med=3.58ms  max=81.35ms p(90)=10.25ms p(95)=16.24ms
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=4.25ms  min=439.61µs med=3.7ms   max=43.51ms p(90)=6.97ms  p(95)=8.3ms  
     ✓ { mode:envelop-cache-jit }.......................: avg=2.53ms  min=195.7µs  med=1.87ms  max=39.18ms p(90)=4.73ms  p(95)=8.31ms 
     ✓ { mode:envelop-just-cache }......................: avg=4.27ms  min=411.1µs  med=3.6ms   max=73.7ms  p(90)=7.3ms   p(95)=8.44ms 
     ✓ { mode:graphql-js }..............................: avg=7.5ms   min=748.51µs med=6.4ms   max=79.16ms p(90)=12.15ms p(95)=13.87ms
     ✓ { mode:prom-tracing }............................: avg=18.66ms min=2.09ms   med=16.59ms max=81.35ms p(90)=32.17ms p(95)=33.36ms
     http_req_failed....................................: 0.00%   ✓ 0          ✗ 287733
     http_req_receiving.................................: avg=48.96µs min=12.3µs   med=22.3µs  max=17.68ms p(90)=34.29µs p(95)=40.2µs 
     http_req_sending...................................: avg=35.01µs min=4.8µs    med=7.9µs   max=28.96ms p(90)=14.4µs  p(95)=18.5µs 
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=4.78ms  min=167.8µs  med=3.54ms  max=81.29ms p(90)=9.97ms  p(95)=16.16ms
     http_reqs..........................................: 287733  1918.09728/s
     iteration_duration.................................: avg=5.2ms   min=414.71µs med=3.84ms  max=84.5ms  p(90)=10.78ms p(95)=16.58ms
     iterations.........................................: 287733  1918.09728/s
     vus................................................: 0       min=0        max=20  
     vus_max............................................: 20      min=20       max=20

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023 •
edited
Loading

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/core 4.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/apollo-datasources 3.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/apollo-federation 4.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/apollo-server-errors 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/apollo-tracing 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/auth0 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/dataloader 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/depth-limit 3.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/disable-introspection 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/execute-subscription-event 4.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/extended-validation 3.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/filter-operation-type 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/fragment-arguments 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/generic-auth 6.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/graphql-jit 6.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/graphql-middleware 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/graphql-modules 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/immediate-introspection 2.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/live-query 6.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/newrelic 6.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/on-resolve 3.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/opentelemetry 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/operation-field-permissions 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/parser-cache 6.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/persisted-operations 6.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/preload-assets 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/prometheus 8.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/rate-limiter 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/resource-limitations 4.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/response-cache 5.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/response-cache-redis 3.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/sentry 6.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/statsd 4.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/validation-cache 6.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/testing 6.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎
@envelop/types 4.0.0-alpha-20230522145711-c4d816fe npm ↗︎ unpkg ↗︎

n1ru4l
n1ru4l reviewed May 22, 2023
View reviewed changes
.github/workflows/pr.yml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023 •
edited
Loading

💻 Website Preview

The latest changes are available as preview in: https://5e42a854.envelop.pages.dev

@n1ru4l
Copy link
Owner

n1ru4l commented May 22, 2023 •
edited
Loading

tsconfig target and lib can be bumped to es2021, see https://github.com/kamilkisiela/graphql-config/blob/master/tsconfig.json#L4-L5

@ardatan
Copy link
Collaborator Author

ardatan commented May 22, 2023

Done @n1ru4l 👍

@ardatan ardatan requested a review from n1ru4l May 22, 2023 14:59
@ardatan ardatan merged commit 332f1f2 into main May 22, 2023
@theguild-bot theguild-bot mentioned this pull request May 22, 2023
Merged
@ardatan ardatan deleted the drop-node14 branch June 22, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotansimha dotansimha dotansimha approved these changes

@n1ru4l n1ru4l Awaiting requested review from n1ru4l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ardatan @theguild-bot @n1ru4l @dotansimha